Skip to content

Commit 2d9370a

Browse files
committed
fix: address suggestions
1 parent 50d5fd7 commit 2d9370a

File tree

3 files changed

+18
-21
lines changed

3 files changed

+18
-21
lines changed

.github/workflows/release.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ jobs:
2020
with:
2121
python-version: 3.8
2222

23-
- name: Install Semantic Release
24-
run: make install-semantic-release
23+
- name: Install dependencies
24+
run: |
25+
pip install -e .[dev]
2526
2627
- name: Run Semantic Release
2728
run: make release

Makefile

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
.DEFAULT_GOAL := help
22

3-
install-semantic-release: ## install semantic-release
4-
@echo "Installing semantic-release."
5-
pip install python-semantic-release
6-
73
release: ## release a new version
84
@echo "Releasing a new version."
5+
@echo "This is a remote release, it will push to the remote repository."
96
semantic-release -vv version --changelog --push --tag --commit
107

8+
local-release:
9+
@echo "Releasing a new version."
10+
@echo "This is a local release, it will not push to the remote repository."
11+
@echo "You can push the changes and release manually."
12+
semantic-release -vv version --changelog --commit --no-push
13+
1114
selfcheck: ## check that the Makefile is well-formed
1215
@echo "The Makefile is well-formed."
1316

pyproject.toml

Lines changed: 8 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
44

55
[project]
66
name = "drydock"
7-
version = "17.3.4"
7+
dynamic = ["version"]
88
description = "A Tutor plugin to manage our opinionated Open edX operations"
99
readme = "README.md"
1010
requires-python = ">=3.8"
@@ -28,6 +28,11 @@ dependencies = [
2828
"tutor>=17.0.2,<18.0.0"
2929
]
3030

31+
[project.optional-dependencies]
32+
dev = [
33+
"python-semantic-release",
34+
]
35+
3136
[project.urls]
3237
Homepage = "https://github.com/edunext/drydock"
3338
Code = "https://github.com/edunext/drydock"
@@ -40,20 +45,14 @@ exclude = ["tests*"]
4045
[project.entry-points."tutor.plugin.v1"]
4146
drydock = "drydock.plugin"
4247

43-
[tool.isort]
44-
include_trailing_comma = true
45-
indent = " "
46-
line_length = 120
47-
multi_line_output = 3
48+
[tool.setuptools.dynamic]
49+
version = {attr = "drydock.__about__.__version__"}
4850

4951
[tool.wheel]
5052
universal = true
5153

5254
[tool.semantic_release]
5355
commit_message = "chore(release): preparing {version}"
54-
version_toml = [
55-
"pyproject.toml:project.version",
56-
]
5756
version_variables = [
5857
"drydock/__about__.py:__version__",
5958
]
@@ -63,9 +62,3 @@ match = "(main|master)"
6362

6463
[tool.semantic_release.changelog.environment]
6564
keep_trailing_newline = true
66-
67-
[tool.semantic_release.remote]
68-
name = "origin"
69-
type = "github"
70-
ignore_token_for_push = false
71-
insecure = false

0 commit comments

Comments
 (0)