Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 'global' check algorithm to latest umdjs guided #27

Open
fuweichin opened this issue Jun 4, 2020 · 0 comments
Open

Update the 'global' check algorithm to latest umdjs guided #27

fuweichin opened this issue Jun 4, 2020 · 0 comments

Comments

@fuweichin
Copy link

fuweichin commented Jun 4, 2020

Overview:
gulp-umd templates is out of sync with umdjs templates.

The Problem:
As the 'global' check algorithm gulp-umd currently using in templates is deprecated, files generated gulp-umd have two serious problems:

  • cannot be loaded with native ES module loader
    import '/node_modules/js-untar/build/dist/untar.js';
  • not working properly in Firefox browser extension environment

The error looks like:

Cannot set property 'xxx' of undefined

because the outer this, or argument root in IIF, is undefined

see InvokIT/js-untar#30 and markedjs/marked#1292

Possible Solution:
Update the global check algorithm to umdjs's latest recommended way.

say, replace this with typeof self !== 'undefined' ? self : this, see returnExportsGlobal.js for example.

This is a serious problem, plz patch latest 3 versions (2.x, 1.x anf 0.2.x), also set deprecated tag on old versions at npm central registry.

@fuweichin fuweichin changed the title UMD compliance Update the 'global' check algorithm to latest umdjs guided Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant