Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Audit Vitality Code Source (Thibault) #29

Open
tollr opened this issue Nov 5, 2024 · 1 comment
Open

[FEATURE]: Audit Vitality Code Source (Thibault) #29

tollr opened this issue Nov 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tollr
Copy link

tollr commented Nov 5, 2024

Hey there, I reviewed v6y code and here are the items which stood out :)

v6y-front

  • Use i18next
  • *QueryType interface => could these types be factorized to avoid duplicating them? The only changing part is the name of the query which (to me) has no practical use to be here.
  • Fix Cannot find name React :
    • global-error.tsx
    • loading.tsx
    • not-found.tsx
  • Dynamic imports : disable eslint (react/display-name) or use a named function for the component returned by loading
  • VitalityAuditReportsTypeGrouper.tsx:31-38 => I don't get the conditions
dataSource={[
    ...(auditReports?.filter(
        (report) => report?.type === AUDIT_REPORT_TYPES.lighthouse,
    ) || []),
    ...(auditReports?.filter(
        (report) => report?.type !== AUDIT_REPORT_TYPES.lighthouse,
    ) || []),
]}

v6y-front-bo

  • Utils for auth getData to avoid code duplication?
  • improve typing for generic Refine*Wrapper => data is inferred as unknown
  • UseNavigationAdapter is used in both this package and v6y-front => move it to v6y-commons ?

Congrats for the current work 💪

@tollr tollr added the enhancement New feature or request label Nov 5, 2024
@helabenkhalfallah helabenkhalfallah changed the title [FEATURE]: review [FEATURE]: code Audit (Thibault) Nov 5, 2024
@helabenkhalfallah
Copy link
Member

Thank you so much for these different feedbacks, we'll take them into account. :) :)

@helabenkhalfallah helabenkhalfallah added this to the Vitality 1.1 milestone Nov 5, 2024
@helabenkhalfallah helabenkhalfallah self-assigned this Nov 5, 2024
@helabenkhalfallah helabenkhalfallah changed the title [FEATURE]: code Audit (Thibault) [FEATURE]: Audit Vitality Code Source (Thibault) Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants