Let's add workflows for refactor and new features

[strawgate]

Let's setup a workflow with a senior architect who thinks we should perform a refactor of the codebase. Force them to partially implement it to ensure it's viable, and then pitch the refactor via a created issue

Let's setup a workflow for an ideas man like we did here elastic/ai-github-actions-playground#30

Let's scope out additional "continuous improvement" flows we might want

[github-actions]

3 related issues

• Identify additional workflows #275 — it tracks identifying additional useful workflows and overlaps with this issue’s request to scope more continuous-improvement flows.
• Add workflow drift trigger #257 — it covers workflow drift after refactors, which is adjacent to this issue’s refactor-oriented workflow proposal.
• Create an agent that suggests new agents #129 — it proposes a recurring workflow to suggest new agents, which could inform how to operationalize the new-ideas workflow requested here.

---

What is this? | From workflow: Duplicate Issue Detector

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[github-actions]

The repo already has strong building blocks for this (code-simplifier, code-duplication-detector/fixer, and agent-suggestions), so I recommend adding one new refactor-architect workflow and expanding agent-suggestions for feature-idea generation instead of creating two fully separate net-new systems.

Recommendation

1. Add refactor-architect as a scheduled detector workflow (issue output, not PR output) built on scheduled-audit, but require a local proof step (small candidate patch + command results) embedded in the issue report.
2. Use/extend agent-suggestions for new-feature ideation (it already inventories workflows, checks repo/downstream signals, and files suggestion issues).
3. Align safe-output lifecycle with ongoing work in Improve defaults for close older issues #357 / PR Improve close-older-issues defaults for auditor/detector workflows #358: for recurring detectors/audits, default close-older-issues: false so independent findings are not auto-closed.

Findings

• Existing refactor coverage is already split between:
  • gh-agent-workflows/code-simplifier/README.md:1-8 (safe, behavior-preserving refactors, PR output)
  • gh-agent-workflows/code-duplication-detector/README.md:1-8 (refactor recommendations, issue output)
  • gh-agent-workflows/code-duplication-fixer/README.md:1-8 (executes detector findings into PRs)
• Existing “new workflow ideas” coverage already exists:
  • gh-agent-workflows/agent-suggestions/README.md:1-8
  • .github/workflows/gh-aw-agent-suggestions.md:88-123 (explicitly proposes 1–3 new workflows with evidence).
• A reusable base for your requested “report-first architect workflow” already exists:
  • .github/workflows/gh-aw-scheduled-audit.md:3-5,80-87
  • .github/workflows/gh-aw-fragments/scheduled-audit.md:9-10,41-42 (detection/reporting only; output is issue or noop).
• Quick setup already has a “continuous improvement” bundle, including refactor-oriented workflows:
  • gh-agent-workflows/README.md:61-73
  • scripts/quick-setup.sh:128-140.
• Related prior work confirms this direction is incremental (not duplicate):
  • Add code simplifer agent #75 + PR Add code simplifier agent workflow #81 introduced Code Simplifier
  • Code Simplifier improvements #172 + PR Code Simplifier: raise bar to avoid trivial micro-changes #177 tightened the “high-value refactor only” bar
  • Identify additional workflows #275 tracked adding additional workflows
  • Improve defaults for close older issues #357 + PR Improve close-older-issues defaults for auditor/detector workflows #358 is actively refining detector issue-lifecycle defaults.

Verification

I ran workflow linting to confirm current workflow set/config compiles cleanly before proposing additions:

$ make lint-workflows
...
Checking .github/workflows/trigger-code-simplifier.yml...
Checking .github/workflows/trigger-code-duplication-detector.yml...
...
(exited with exit code 0)

This verifies the current baseline is healthy and ready for incremental workflow additions.

Detailed Action Plan

1. Create new workflow source

   • Add .github/workflows/gh-aw-refactor-architect.md using the same structure as .github/workflows/gh-aw-code-duplication-detector.md (imports, engine, permissions, tools, safe outputs).
   • Base it on scheduled-audit (.github/workflows/gh-aw-scheduled-audit.md:3-5) and set report format to include:
     • target refactor candidate,
     • minimal proposed patch summary,
     • commands run + outputs,
     • rollback/risk notes.

2. Set safe output behavior for recurring reports

   • In the new workflow, configure create-issue title prefix (e.g. [refactor-architect]).
   • Use detector-style lifecycle defaults consistent with Improve defaults for close older issues #357/PR Improve close-older-issues defaults for auditor/detector workflows #358 direction (do not auto-close prior unrelated findings).

3. Add installable trigger and docs

   • Add gh-agent-workflows/refactor-architect/example.yml (weekday schedule + workflow_dispatch, calling new .lock.yml).
   • Add gh-agent-workflows/refactor-architect/README.md following current per-workflow README pattern.

4. Extend feature ideation path

   • Update .github/workflows/gh-aw-agent-suggestions.md:88-123 to explicitly include “new feature workflow proposals” (not only generic workflow suggestions).
   • Update gh-agent-workflows/agent-suggestions/README.md:3-8 to reflect feature ideation scope.

5. Expose in catalogs + setup

   • Update gh-agent-workflows/README.md and docs/workflows/gh-agent-workflows.md tables to include refactor-architect and the expanded agent-suggestions description.
   • Add refactor-architect to scripts/quick-setup.sh:128-140 continuous improvement list.

6. Compile and validate

   • Run make compile (regenerate lock files/triggers), then make lint (or at minimum make lint-workflows).
   • Confirm new trigger appears as .github/workflows/trigger-refactor-architect.yml and lockfile exists.

Related Items

Type	Link	Relevance
Issue	#359	Current request
Issue	#275	Prior “identify additional workflows” request
Issue	#75	Added Code Simplifier concept
Issue	#172	Refined simplifier quality bar
Issue	#357	Detector/auditor issue lifecycle defaults
PR	#81	Added code-simplifier workflow
PR	#177	Raised simplifier threshold (avoid micro-refactors)
PR	#180	Expanded quick-setup continuous-improvement bundle
PR	#358	In-flight close-older-issues default improvements
File	.github/workflows/gh-aw-scheduled-audit.md	Best base for report-first architect workflow
File	.github/workflows/gh-aw-agent-suggestions.md	Best place to extend feature-idea generation
File	scripts/quick-setup.sh	Installs workflow bundles
Web	elastic/ai-github-actions-playground#30	Referenced ideation pattern

---

What is this? | From workflow: Issue Triage

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

[strawgate]

no the Ideas Guy should be its own workflow not combined with agent suggestions, agent suggestions is for suggesting new agents, ideas guy is a workflow our downstream consumers will use