Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nuget Packages should have licence info #2258

Closed
thompson-tomo opened this issue Jan 21, 2024 · 0 comments · Fixed by #2264
Closed

Nuget Packages should have licence info #2258

thompson-tomo opened this issue Jan 21, 2024 · 0 comments · Fixed by #2264
Labels
agent-dotnet community enhancement New feature or request triage

Comments

@thompson-tomo
Copy link
Contributor

thompson-tomo commented Jan 21, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
When my packages are analyzed in Dependency Track using SBOM files the licence is not able to be determined for any of the Elastic.APM packages.

Describe the solution you'd like
The PackageLicenseExpression property is set in the csproj so that the NUGET package has the information. This can then be included in the SBOM so that analysis can occur in the appropriate tools. This would be just like Elastic.CommonSchema does it.

Describe alternatives you've considered
Ignore the errors.

Additional context
N/a
@thompson-tomo thompson-tomo added the enhancement New feature or request label Jan 21, 2024
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue Jan 27, 2024
@thompson-tomo
elastic#2258 Switch to Licence expression rather than file
45edb8f
@thompson-tomo thompson-tomo mentioned this issue Jan 27, 2024
Merged
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue Feb 3, 2024
@thompson-tomo
elastic#2258 Switch to Licence expression rather than file
e790958
thompson-tomo added a commit to thompson-tomo/apm-agent-dotnet that referenced this issue Feb 4, 2024
@thompson-tomo
elastic#2258 Switch to Licence expression rather than file
3e58b83
@Mpdreamz Mpdreamz closed this as completed Feb 7, 2024
Mpdreamz pushed a commit that referenced this issue Feb 7, 2024
@thompson-tomo
Switch to Licence expression rather than file (#2264)
be1655d 
* #2258  Switch to Licence expression rather than file

* Update project url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-dotnet community enhancement New feature or request triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch to Licence expression rather than file thompson-tomo/apm-agent-dotnet
2 participants
@Mpdreamz @thompson-tomo