Skip to content

Commit 9926756

Browse files
committed
Minor improvements
1 parent 7fc81c3 commit 9926756

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

tests/ElasticApmTests/ComponentTests/Util/HttpServerTestEnvBase.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ protected function sendRequestToInstrumentedApp(TestProperties $testProperties):
3939
{
4040
$this->ensureMockApmServerRunning();
4141
$this->ensureAppCodeHostServerRunning($testProperties);
42+
TestCase::assertNotNull($this->appCodeHostServerPort);
43+
TestCase::assertNotNull($this->appCodeHostServerId);
4244

4345
($loggerProxy = $this->logger->ifDebugLevelEnabled(__LINE__, __FUNCTION__))
4446
&& $loggerProxy->log(
4547
'Sending HTTP request `' . $testProperties->httpMethod . ' ' . $testProperties->uriPath . '\''
4648
. ' to ' . DbgUtil::fqToShortClassName(BuiltinHttpServerAppCodeHost::class) . '...'
4749
);
4850

49-
/** @noinspection PhpUnhandledExceptionInspection */
50-
/** @phpstan-ignore-next-line - Call to static method ... on trait */
5151
$response = TestHttpClientUtil::sendHttpRequest(
5252
$this->appCodeHostServerPort,
5353
$this->appCodeHostServerId,

tests/ElasticApmTests/ComponentTests/Util/StatefulHttpServerProcessBase.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,9 @@ protected function beforeLoopRun(LoopInterface $loop): void
108108
{
109109
}
110110

111-
protected function shouldRequestHaveServerId(ServerRequestInterface $request): bool
112-
{
111+
protected function shouldRequestHaveServerId(
112+
/** @noinspection PhpUnusedParameterInspection */ ServerRequestInterface $request
113+
): bool {
113114
return true;
114115
}
115116

0 commit comments

Comments
 (0)