Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for multi-valued global labels #189

Closed
carsonip opened this issue Aug 9, 2024 · 1 comment · Fixed by #191
Closed

Add tests for multi-valued global labels #189

carsonip opened this issue Aug 9, 2024 · 1 comment · Fixed by #191
Assignees
@endorama

Comments

@carsonip
Copy link
Member

carsonip commented Aug 9, 2024

Multi-valued global labels suffered from a bug fixed in #186 where aggregated metrics would use the incorrect multi-valued global labels. Add tests to cover cases where there are at least 2 sets of different multi-valued global labels.
@endorama endorama mentioned this issue Aug 14, 2024
Merged
@endorama
Copy link
Member

PR with a fix is ready for a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@endorama endorama

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add global labels value regression tests elastic/apm-aggregation
2 participants
@endorama @carsonip