Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate go-docappender metrics are produced when monitoring is enabled #13244

Closed
kruskall opened this issue May 28, 2024 · 7 comments
Closed
Labels
bug operational Tasks to be picked up during support rotation

Comments

@kruskall
Copy link
Member

We should make sure that go-docappender metrics are produced when monitoring is enabled.

flush latency and similar metrics are important to debug issues

@kruskall kruskall added bug operational Tasks to be picked up during support rotation labels May 28, 2024
@carsonip
Copy link
Member

carsonip commented May 28, 2024

go-docappender itself exposes metrics as OTel metrics, as opposed to elastic agent monitoring where EA polls metrics from APM server. The go-docappender metrics should be available if instrumentation.enabled is true in apm-server.yml because apm-server configures otel bridge.

@carsonip
Copy link
Member

carsonip commented May 29, 2024

I looked into this again. apm-server does get stats from the appender and publish libbeat monitoring metrics, other than the fact that go-docappender publishes OTel metrics itself (what I mentioned in the previous comment).

The observation is that there are no output.elasticsearch.bulk_requests metrics published by this code, but I see output.events.* metrics. This may reveal a bug somewhere. I wonder if using the monitoring.Default registry is causing a problem. This issue has to be investigated.

@carsonip
Copy link
Member

Might be related to #8383

@carsonip
Copy link
Member

Observation: when monitoring.enabled: true and monitoring.elasticsearch is configured, the metrics are sent to ES directly under .monitoring-beats-7-*. The output.elasticsearch.* fields exist in source but are unmapped.

@carsonip
Copy link
Member

In that case there may be 2 problems:

  1. the .monitoring-beats-7-* does not have the mappings for some of our fields
  2. metricbeat beat module may be ignoring the fields because some of our fields do not fall into "exported fields" defined by metricbeat. Pending confirmation.

@carsonip
Copy link
Member

metricbeat beat module may be ignoring the fields because some of our fields do not fall into "exported fields" defined by metricbeat. Pending confirmation.

(2) is not right. The mapping is actually defined in EA integration. Created #13475 to take care of missing metrics due to EA integration apm-server metrics mapping.

@elastic elastic deleted a comment from rnyburia Jul 9, 2024
@carsonip
Copy link
Member

It should be closed by #13475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug operational Tasks to be picked up during support rotation
Projects
None yet
Development

No branches or pull requests

2 participants