packetbeat/{beater,protos,sniffer}: allow assignment of protocols to interfaces #36852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Packetbeat
Team:Security-External Integrations
backport-skip
botelastic
bot
added
needs_team
efd6
changed the title
efd6
force-pushed
the
36574-packetbeat_distribute_work
branch
from
a10e1fd to
09512c3
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
efd6
force-pushed
the
36574-packetbeat_distribute_work
branch
3 times, most recently
from
4ad779a to
0c9d36d
Compare
…interfaces Previously the protocols association was held in a *protocols.ProtocolStruct in common for all interfaces. This prevented individual interfaces that were only associated with a subset of the protocols that were being captured from working specifically on that subset. The new code moves the construction of the protocols sets into setupSniffer where they are associated with the interface that will be capturing them. They are then assigned to child sniffers in sniffer.New based on the interface. This change has no effect on the behaviour of packetbeat as it stands as configs from packetbeat and from agent are only able to express the existence of a single interface. Changes to configuration format/shape will enable multiple interfaces to be enabled in packetbeat and within a single agent policy, making use of the change here.
efd6
force-pushed
the
36574-packetbeat_distribute_work
branch
from
0c9d36d to
69e4e92
Compare
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
approved these changes
Nov 12, 2023
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…interfaces (elastic#36852) Previously the protocols association was held in a *protocols.ProtocolStruct in common for all interfaces. This prevented individual interfaces that were only associated with a subset of the protocols that were being captured from working specifically on that subset. The new code moves the construction of the protocols sets into setupSniffer where they are associated with the interface that will be capturing them. They are then assigned to child sniffers in sniffer.New based on the interface. This change has no effect on the behaviour of packetbeat as it stands as configs from packetbeat and from agent are only able to express the existence of a single interface. Changes to configuration format/shape will enable multiple interfaces to be enabled in packetbeat and within a single agent policy, making use of the change here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Previously the protocols association was held in a *protocols.ProtocolStruct in
common for all interfaces. This prevented individual interfaces that were only
associated with a subset of the protocols that were being captured from working
specifically on that subset. The new code moves the construction of the protocols
sets into setupSniffer where they are associated with the interface that will be
capturing them. They are then assigned to child sniffers in sniffer.New based on
the interface.
This change has no effect on the behaviour of packetbeat as it stands as configs
from packetbeat and from agent are only able to express the existence of a single
interface. Changes to configuration format/shape will enable multiple interfaces
to be enabled in packetbeat and within a single agent policy, making use of the
change here.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs