-
Notifications
You must be signed in to change notification settings - Fork 5k
remove otel.component.id and otel.component.kind fields from beat receivers #47729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove otel.component.id and otel.component.kind fields from beat receivers #47729
Conversation
🤖 GitHub commentsJust comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
khushijain21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@narph Could we have your approval here please? |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
@efd6 / @andrewkroh could you please take a look here? |
|
Thanks. The cost of having these fields turned out to be higher than I initially anticipated when I proposed them. Looking at it from a different perspective now, I believe that if we ever want something like this back, Elastic Agent should probably be the one responsible for adding them. |
…eivers (#47729) * remove component id and component kind fields from beat receivers * add real PR link * update integration tests * fix merge mistake (cherry picked from commit ca1c17b) # Conflicts: # x-pack/filebeat/tests/integration/otel_lsexporter_test.go # x-pack/libbeat/outputs/otelconsumer/otelconsumer.go # x-pack/libbeat/outputs/otelconsumer/otelconsumer_test.go
…eivers (#47729) * remove component id and component kind fields from beat receivers * add real PR link * update integration tests * fix merge mistake (cherry picked from commit ca1c17b) # Conflicts: # x-pack/filebeat/input/gcppubsub/otel_test.go # x-pack/filebeat/tests/integration/otel_lsexporter_test.go # x-pack/filebeat/tests/integration/otel_test.go # x-pack/libbeat/outputs/otelconsumer/otelconsumer.go # x-pack/libbeat/outputs/otelconsumer/otelconsumer_test.go # x-pack/metricbeat/mbreceiver/receiver_test.go
…nd fields from beat receivers (#47788) * remove otel.component.id and otel.component.kind fields from beat receivers (#47729) * remove component id and component kind fields from beat receivers * add real PR link * update integration tests * fix merge mistake (cherry picked from commit ca1c17b) * fix test case that wasn't on main --------- Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com> Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co>
Proposed commit message
remove
otel.component.idandotel.component.kindfrom events that were generated by beat receivers.The cost of sending the extra data in every event was found to be not worth the value of having the fields.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
If anyone was using the fields to track beat receiver events, they won't be available anymore. However, the fields we not documented publicly and were not part of an API.
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs