-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link checking fails on external links #182
Comments
The cross-link syntax is already accepted by docs-builder. Hence, if you add a link like this:
Also see #168 Then, the build will succeed. However, we are not yet resolving the link as it might still depend on the assembler on how it's resolved. |
I see two options here:
WDYT? |
These are real failures that need addressing but we can make links with That way they still get flagged and folks can start addressing them. e.g
The first is something perhaps the migration tool can unroll automatically? The latter maybe too but requires a more complex mapping of elastic.co urls to repository names. |
Ah, I just discovered that Does this change anything? @Mpdreamz |
No we still don't want links like these moving forward. We don't want variables in links and these links should point to documentation files not URLs. |
This will add a warning if the string contains |
Related #182 ## Details Add warning if a link contains `{{` or `}}` thus using a template expression. Because 1) it doesn't work 2) it's discouraged to use template variables in links
I this solved with #191? |
Summary
The build is trying to link check links that don't exist. These links are failing. You can find examples in https://github.com/elastic/observability-docs.md/actions/runs/12758638542/job/35561040730. A couple of examples are below:
Expected behavior
We can't let these failures prevent the build from succeeding. These links will not work until we move content around and replace this link syntax with the new link syntax/system that Jan is building.
The text was updated successfully, but these errors were encountered: