Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPG and GIF images are not rendered #308

Closed
1 of 3 tasks
kosabogi opened this issue Jan 22, 2025 · 3 comments · Fixed by #370
Closed
1 of 3 tasks

JPG and GIF images are not rendered #308

kosabogi opened this issue Jan 22, 2025 · 3 comments · Fixed by #370
Assignees
Labels
authoring Relates to our markdown parser bug

Comments

@kosabogi
Copy link

Describe the bug

In the Machine Learning book, images in JPG format are not rendering at all.
However, images in PNG format appear to render correctly.

Image

Expected behavior

Images should render correctly regardless of whether they are in JPG or PNG format.

Steps to reproduce

No response

Tooling

  • docs-builder
  • migration tooling
  • I'm not sure
@kosabogi kosabogi added the bug label Jan 22, 2025
@colleenmcginnis
Copy link

GIFs are also not rendered, like here:

Image

@colleenmcginnis colleenmcginnis changed the title JPG images are not rendered JPG and GIF images are not rendered Jan 22, 2025
@bmorelli25
Copy link
Member

bmorelli25 commented Jan 23, 2025

I'm also seeing an issue with SVGs: https://refactored-funicular-qzy2pnj.pages.github.io/apm-getting-started-apm-server.html#_help_me_decide

EDIT: This SVG issue is likely unrelated.

@bmorelli25 bmorelli25 added migration-tool authoring Relates to our markdown parser and removed migration-tool labels Jan 23, 2025
@bmorelli25 bmorelli25 marked this as a duplicate of #303 Jan 23, 2025
@Mpdreamz
Copy link
Member

The SVG issues is unrelated:

https://github.com/elastic/observability-docs/blob/8.17/docs/en/observability/apm/diagrams/apm-decision-tree.asciidoc?plain=1

We won't support embedded SVG html, these will need to be embedded using the image syntax:

![text](path_to_svg)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authoring Relates to our markdown parser bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants