New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PR Previews to elastic/docs-content #339

Closed

9 tasks

bmorelli25 opened this issue Jan 24, 2025 · 6 comments

Assignees

Labels

automation

Member

bmorelli25 commented Jan 24, 2025 •

edited

Loading

Summary

Add PR previews to each of the individual content sets in https://github.com/elastic/docs-content:

Related

Requires #48.

bmorelli25 added the automation label

bmorelli25 mentioned this issue

Add PR Builds and Previews #48

Closed

Member

reakaleek commented Jan 24, 2025

Do I understand correctly,

If there is a change e.g. in deploy-manage and elastic-basics there should be two previews?

Another question, the filename is doset.yml. Is this a bug?

Member Author

bmorelli25 commented Jan 24, 2025

If there is a change e.g. in deploy-manage and elastic-basics there should be two previews?

IIUC, this is the only way to get PR previews working in docs-content prior to the assembler being ready.

Another question, the filename is doset.yml. Is this a bug?

Hah. Yes, this is a bug.

Member

Mpdreamz commented Jan 27, 2025

See: elastic/docs-content#257

elastic/docs-content will only have 1 docset.yml file and multiple toc.yml files within the top level folders.

Our current build and previews actions will work out of the box on elastic/docs-content

reakaleek self-assigned this

Member

reakaleek commented Jan 28, 2025

docs-builder currently fails if the docset.yml is in the root directy and not in a /docs folder.

This will fix it #360

Member

reakaleek commented Jan 28, 2025

It's deployed now https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/262 through elastic/docs-content#262

But I still need to do some fine tuning.

Member

reakaleek commented Jan 31, 2025

elastic/docs-content#262

reakaleek closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment