Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure all configurations defined on artifacts.Config are reloades #3940

Open
AndersonQ opened this issue Dec 20, 2023 · 1 comment
Labels
Team:Elastic-Agent Label for the Agent team

Comments

@AndersonQ
Copy link
Member

Describe the enhancement:

#3937 adds a test ensuring the current artifact.Config is all reloaded. However it cannot account for future additions on the struct or settings. Therefore a test which verifies all properties on artifact.Config are tested must be created.
So far the idea is the test should ensure the current test uses all possible configurations/keys rather than generating a random config file from artifact.Config.

Describe a specific use case for the enhancement or feature:
If artifact.Config is updated, the new fields won't be covered by tests.

What is the definition of done?

A new property added to artifact.Config will cause the test of the upgrade reloader to fail.

@AndersonQ AndersonQ added the Team:Elastic-Agent Label for the Agent team label Dec 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

No branches or pull requests

2 participants