Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: User is able to add duplicate tags to Agents #858

Closed
ghost opened this issue Aug 4, 2022 · 8 comments · Fixed by #3740
Closed

[Fleet]: User is able to add duplicate tags to Agents #858

ghost opened this issue Aug 4, 2022 · 8 comments · Fixed by #3740
Assignees
Labels
bug Something isn't working impact:low Long-term priority, unless it's a quick fix. QA:Validated Validated by the QA Team Team:Elastic-Agent Label for the Agent team

Comments

@ghost
Copy link

ghost commented Aug 4, 2022

Kibana version: 8.4 Snapshot Kibana cloud environment

Host OS and Browser version: All, All

Build Details:

Version: 8.4.0 BC2
Build: 55166
Commit: 9e9e0d6a685cbc2858a85a357f93dcb76259fdee

Preconditions:

  • 8.4 Kibana cloud environment should be available.
  • An Agent policy should be created.

Steps to reproduce:

  1. Extract the artifacts and Navigate to the artifacts location on Windows PowerShell
  2. Run the below commands on Windows PowerShell to install an Agent with tags

.\elastic-agent.exe install --url=xxxxx:443 --enrollment-token=xxxxx --tag=win,win2,flag,class,happy,abc,XYZ,network,class

  1. Elastic Agent gets installed
  2. Navigate to Fleet>Agents tab.
  3. Observe Agent is installed with duplicate tags

Expected Result:

  • User should not be able to add duplicate tags to Agents

Screenshots:

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-08-04.13-22-24.mp4
@ghost ghost added bug Something isn't working impact:low Long-term priority, unless it's a quick fix. Team:Fleet Label for the Fleet team labels Aug 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ghost
Copy link
Author

ghost commented Aug 4, 2022

@manishgupta-qasource Please review

@manishgupta-qasource
Copy link

Secondary review for this ticket is Done

@juliaElastic juliaElastic transferred this issue from elastic/kibana Aug 4, 2022
@juliaElastic juliaElastic added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team and removed Team:Fleet Label for the Fleet team labels Aug 4, 2022
@juliaElastic
Copy link
Contributor

The enroll command is not maintained by kibana, redirecting this issue to elastic-agent project.

@ghost
Copy link
Author

ghost commented Dec 28, 2022

Hi @jlind23,

We have re-validated this issue on the latest 8.6.0 SNAPSHOT Kibana Staging environment and found that the issue is still reproducible.

Below are the observations:

  • User is able to add duplicate tags to Agents via elastic-agent enrollment command.

Screenshots:

image

Agents.-.Fleet.-.Elastic.-.Google.Chrome.2022-12-28.13-50-35.mp4

Build details:

Version: 8.6.0 SNAPSHOT
Build: 58831	
Commit: b4a10d435656cddb612f985c4616b3b715ffe7a8

Please let us know if anything else is required from our end.

Thanks!

@cmacknz cmacknz added Team:Elastic-Agent Label for the Agent team and removed Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jan 4, 2023
@amolnater-qasource
Copy link

Hi @cmacknz

We have revalidated this issue on latest 8.10.0 SNAPSHOT kibana cloud environment and found it still reproducible.

Observations:

  • User can add duplicate tags to agents from the command, and gets no error.
  • However, only single tag is visible under Fleet UI.

Could you please confirm if there will be any update in the agent installation command?
Please feel free to close this issue if no changes are required.

Screenshot:
image

image

Build details:
VERSION: 8.10.0 SNAPSHOT
BUILD: 65561
COMMIT: 4dadcbb91136a3e7d39e4b419aa12e21a37e4918

Please let us know if anything else is required from our end.

cc: @jlind23
Thanks!

@jlind23
Copy link
Contributor

jlind23 commented Aug 16, 2023

@amolnater-qasource I do think this is a "bug" but I don't see any urgency here so I will put that in our backlog.
cc @pierrehilbert

@pierrehilbert pierrehilbert self-assigned this Nov 10, 2023
@amolnater-qasource amolnater-qasource added the QA:Ready For Testing Code is merged and ready for QA to validate label Nov 14, 2023
@harshitgupta-qasource
Copy link

harshitgupta-qasource commented Nov 16, 2023

Hi Team,

We have re-validated this issue on the latest 8.12.0 SNAPHOT Kibana cloud environment and found it fixed now.

Observations:

  • Not able to add duplicate tags to Agents.
  • Only single tag is visible under Fleet UI

Screenshots:
image
image

Build details:
VERSION: 8.12.0
BUILD: 69073
COMMIT: 81685d4c5161a77cca43be67e2bd132b6da4391c

Hence, we are marking this issue as QA:Validated.
Thanks!

@harshitgupta-qasource harshitgupta-qasource added QA:Validated Validated by the QA Team and removed QA:Ready For Testing Code is merged and ready for QA to validate labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact:low Long-term priority, unless it's a quick fix. QA:Validated Validated by the QA Team Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants