Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fleet-server] Check support for prerelease qualifiers #4325

Closed
pchila opened this issue Jan 15, 2025 · 1 comment · Fixed by #4328
Closed

[fleet-server] Check support for prerelease qualifiers #4325

pchila opened this issue Jan 15, 2025 · 1 comment · Fixed by #4328
Assignees
@pchila
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@pchila
Copy link
Member

pchila commented Jan 15, 2025

For 9.0 release fleet-server needs to be packaged using prerelease qualifiers, like:

  • beta
  • rc1, rc2

The goal of this issue is to check that the relative packages can be correctly generated, specifically

  • File names contain the prerelease qualifiers
  • version command output correctly prints the specified qualifiers
  • Unified release pipelines work for versions with prerelease qualifiers
  • Release candidate can be re-released as final 9.0 version

Notes:

  • These qualifiers will be used in staging, so there should be no overlap with SNAPSHOT DRA flow
@pchila pchila self-assigned this Jan 15, 2025
@pchila pchila added Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jan 15, 2025
@pchila pchila changed the title Check support for prerelease qualifiers [fleet-server] Check support for prerelease qualifiers Jan 16, 2025
@pchila
Copy link
Member Author

pchila commented Jan 16, 2025 •
edited
Loading

Tested packaging using

 VERSION_QUALIFIER="alpha1" make release

the resulting packages are correct (when compiling the qualified version is set using ldflags -X, for example GOOS=linux GOARCH=amd64 go build -gcflags="" -ldflags="-s -w -X main.Version=9.0.0-alpha1 -X main.Commit=2089b1d7 -X main.BuildTime=2025-01-16T09:01:52Z" -buildmode=pie -o build/binaries/fleet-server-9.0.0-alpha1 -linux-x86_64/fleet-server .

➜  fleet-server git:(main) ✗ tree -L 1 build/distributions
build/distributions
├── fleet-server-9.0.0-alpha1-darwin-aarch64.tar.gz
├── fleet-server-9.0.0-alpha1-darwin-aarch64.tar.gz.sha512
├── fleet-server-9.0.0-alpha1-darwin-x86_64.tar.gz
├── fleet-server-9.0.0-alpha1-darwin-x86_64.tar.gz.sha512
├── fleet-server-9.0.0-alpha1-linux-arm64.tar.gz
├── fleet-server-9.0.0-alpha1-linux-arm64.tar.gz.sha512
├── fleet-server-9.0.0-alpha1-linux-x86_64.tar.gz
├── fleet-server-9.0.0-alpha1-linux-x86_64.tar.gz.sha512
├── fleet-server-9.0.0-alpha1-linux-x86.tar.gz
├── fleet-server-9.0.0-alpha1-linux-x86.tar.gz.sha512
├── fleet-server-9.0.0-alpha1-windows-x86_64.zip
├── fleet-server-9.0.0-alpha1-windows-x86_64.zip.sha512
├── fleet-server-9.0.0-alpha1-windows-x86.zip
└── fleet-server-9.0.0-alpha1-windows-x86.zip.sha512

0 directories, 14 files

version output is correct as well:

➜  fleet-server-9.0.0-alpha1-linux-x86_64 git:(main) ✗ ./fleet-server --version
fleet-server version 9.0.0-alpha1

Will check package script as it uses a VERSION variable which is probably unused

fleet-server/.buildkite/scripts/package.sh

Line 7 in 216f1d0

VERSION=$(awk '/const DefaultVersion/{print $NF}' version/version.go | tr -d '"')

@pchila pchila mentioned this issue Jan 16, 2025
Merged
dliappis added a commit that referenced this issue Jan 17, 2025
@pchila @dliappis
Allow use of version qualifier for staging artifacts (#4328)
29c1d88 
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- elastic/ingest-dev#4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
mergify bot pushed a commit that referenced this issue Jan 17, 2025
@pchila @mergify
Allow use of version qualifier for staging artifacts (#4328)
da9b4fe 
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- https://github.com/elastic/ingest-dev/issues/4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit 29c1d88)
@mergify mergify bot mentioned this issue Jan 17, 2025
Merged
@pchila pchila linked a pull request Jan 17, 2025 that will close this issue
Allow use of version qualifier for staging artifacts #4328
Merged
@pchila pchila closed this as completed Jan 17, 2025
mergify bot pushed a commit that referenced this issue Jan 17, 2025
@pchila @mergify
Allow use of version qualifier for staging artifacts (#4328)
e0d3108 
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- https://github.com/elastic/ingest-dev/issues/4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit 29c1d88)
mergify bot pushed a commit that referenced this issue Jan 17, 2025
@pchila @mergify
Allow use of version qualifier for staging artifacts (#4328)
e4bc57c 
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- https://github.com/elastic/ingest-dev/issues/4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit 29c1d88)
This was referenced Jan 17, 2025
Merged
Merged
pchila added a commit that referenced this issue Jan 17, 2025
@mergify @pchila
Allow use of version qualifier for staging artifacts (#4328) (#4331)
1a93453 
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- https://github.com/elastic/ingest-dev/issues/4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit 29c1d88)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
pchila added a commit that referenced this issue Jan 17, 2025
@mergify @pchila
Allow use of version qualifier for staging artifacts (#4328) (#4333)
28d0a53 
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- https://github.com/elastic/ingest-dev/issues/4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit 29c1d88)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
pchila added a commit that referenced this issue Jan 17, 2025
@mergify @pchila
Allow use of version qualifier for staging artifacts (#4328) (#4332)
5d61d45 
This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- https://github.com/elastic/ingest-dev/issues/4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit 29c1d88)

Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pchila pchila

Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow use of version qualifier for staging artifacts pchila/fleet-server
1 participant
@pchila