Bug: Typedapi Nodes.Info().Do() returns json unmarshalling error.

[hellconnon]

Hey,

when using the typed api client like this:

	esClientSbx, _ := elasticsearch.NewTypedClient(config)
	ctx := context.Background()

	nodesInfo, err := esClientSbx.Nodes.Info().Do(ctx)
	if err != nil {
		fmt.Println("Err: ", err)
	}
	fmt.Println("Info: ",nodesInfo)

i get the following error:

❯ go run .
Err:  Settings | Data | json: cannot unmarshal string into Go value of type []string
Info:  <nil>

I couldn't exactly track down which specific field causes the error.

Edit: I used the filter_path incorrectly and removed the part. The main issue is that the json response cannot be unmarshalled into the info.Response struct anyways.

[hellconnon]

It looks like it is the NodesInfoPath struct in types.nodeinfopath.go, at least that is one place, where it seems to be incorrect.
The struct definition is:

type NodeInfoPath struct {
	Data []string `json:"data,omitempty"`
	Home *string  `json:"home,omitempty"`
	Logs *string  `json:"logs,omitempty"`
	Repo []string `json:"repo,omitempty"`
}

While the API returns:

        "path": {
          "data": "/srv/elasticsearch",
          "logs": "/var/log/elasticsearch/xyz",
          "home": "/usr/share/elasticsearch"

[hellconnon]

In my case changing this definition resolves the error and my api seems to never return an array of strings.
New definition:

// NodeInfoPath type.
//
// https://github.com/elastic/elasticsearch-specification/blob/19027dbdd366978ccae41842a040a636730e7c10/specification/nodes/info/types.ts#L158-L163
type NodeInfoPath struct {
	Data string   `json:"data,omitempty"`
	Home *string  `json:"home,omitempty"`
	Logs *string  `json:"logs,omitempty"`
	Repo []string `json:"repo,omitempty"`
}

But one could also use a custom Type StringOrSliceto cover both cases.