From ef87bceeab3b5b8837d14147956b97c6c19c6678 Mon Sep 17 00:00:00 2001 From: Ying Mao Date: Thu, 7 Dec 2023 16:43:49 -0500 Subject: [PATCH] =?UTF-8?q?Fixes=20Failing=20test:=20X-Pack=20Alerting=20A?= =?UTF-8?q?PI=20Integration=20Tests.x-pack/test/alerting=5Fapi=5Fintegrati?= =?UTF-8?q?on/security=5Fand=5Fspaces/group2/tests/telemetry/alerting=5Fan?= =?UTF-8?q?d=5Factions=5Ftelemetry=C2=B7ts=20-=20alerting=20api=20integrat?= =?UTF-8?q?ion=20security=20and=20spaces=20enabled=20-=20Group=202=20Alert?= =?UTF-8?q?ing=20and=20Actions=20Telemetry=20telemetry=20should=20retrieve?= =?UTF-8?q?=20telemetry=20data=20in=20the=20expected=20format=20(#172701)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Summary Test was failing because a `avg_execution_time > 0` check in the telemetry was returning `false` instead of `true`. I added a short delay to the connector executor to increase the execution time duration slightly to try to avoid this. Ran 450x in the flaky test runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4256 --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> --- .../common/plugins/alerts/server/action_types.ts | 2 ++ .../group2/tests/telemetry/alerting_and_actions_telemetry.ts | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/x-pack/test/alerting_api_integration/common/plugins/alerts/server/action_types.ts b/x-pack/test/alerting_api_integration/common/plugins/alerts/server/action_types.ts index a7d5dbc138ea43..37d66450962b45 100644 --- a/x-pack/test/alerting_api_integration/common/plugins/alerts/server/action_types.ts +++ b/x-pack/test/alerting_api_integration/common/plugins/alerts/server/action_types.ts @@ -45,6 +45,8 @@ export function defineActionTypes( params: { schema: schema.object({}, { defaultValue: {} }) }, }, async executor() { + // add a delay so the execution time is non-zero + await new Promise((r) => setTimeout(r, 1000)); throw new Error('this action is intended to fail'); }, }; diff --git a/x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/telemetry/alerting_and_actions_telemetry.ts b/x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/telemetry/alerting_and_actions_telemetry.ts index ddc90ec10e9b6a..0823665f43f64a 100644 --- a/x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/telemetry/alerting_and_actions_telemetry.ts +++ b/x-pack/test/alerting_api_integration/security_and_spaces/group2/tests/telemetry/alerting_and_actions_telemetry.ts @@ -26,8 +26,7 @@ export default function createAlertingAndActionsTelemetryTests({ getService }: F const esTestIndexTool = new ESTestIndexTool(es, retry); const supertestWithoutAuth = getService('supertestWithoutAuth'); - // FLAKY: https://github.com/elastic/kibana/issues/140973 - describe.skip('telemetry', () => { + describe('test telemetry', () => { const objectRemover = new ObjectRemover(supertest); const alwaysFiringRuleId: { [key: string]: string } = {};