Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Should calculate true value for total number of docs for given date range #195787

Open
sophiec20 opened this issue Oct 10, 2024 · 4 comments
Labels
blocked enhancement New value added to drive a business result Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Team:ESQL ES|QL related features in Kibana

Comments

@sophiec20
Copy link
Contributor

sophiec20 commented Oct 10, 2024

Seen in 8.16 and prior.

The displayed value for total number of documents should not be limited to 1000.

When writing an ES|QL query, a | LIMIT 1000 is added behind-the-scenes. This is a UI-applied guardrail to protect against excessive query load, in place until such time as paging is available and/or optimizations for timestamp ordering.

The LIMIT 1000 does not apply to the time chart because there is an expectation to see the full event rate for the given time range - this mirrors existing KQL functionality.

The LIMIT 1000 applies to the table view - this mirrors existing KQL functionality and avoids too much data being brought back to the UI. This is ok.

However the LIMIT 1000 applies to the doc count (number of docs shown in the tab heading) which seems to be incorrect. Whilst this is the number of docs in the table, it should really show the full doc count for the given time range. This would mirror existing KQL functionality and would show the expected number of docs.

Image

@sophiec20 sophiec20 added bug Fixes for quality problems that affect the customer experience Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Oct 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Oct 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula
Copy link
Contributor

stratoula commented Oct 10, 2024

Related to this #166219

@stratoula stratoula added enhancement New value added to drive a business result blocked and removed bug Fixes for quality problems that affect the customer experience labels Oct 10, 2024
@kertal
Copy link
Member

kertal commented Oct 16, 2024

We were discussing this, and identified this issue as being a part of #196444 with the aim to align DataView and ES|QL behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked enhancement New value added to drive a business result Feature:Discover Discover Application Feature:ES|QL ES|QL related features in Kibana Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) Team:ESQL ES|QL related features in Kibana
Projects
None yet
Development

No branches or pull requests

4 participants