Reimplement LogStash::String setting in Java #16576
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
force-pushed
the
feature/string_setting_to_java
branch
from
f1abaf3
to
8ffcede
Compare
andsel
force-pushed
the
feature/string_setting_to_java
branch
from
c3bcbd5
to
0602b98
Compare
andsel
changed the title
andsel
commented
Nov 12, 2024
| end | ||
| end | ||
| context 'to an invalid value not in the allow-list' do | ||
| let(:possible_strings) { %w(this that)} | ||
| let(:candidate_value) { "another" } # wrong type, expects String | ||
| it 'is an invalid setting' do | ||
| expect { nullable_setting.validate_value }.to raise_error(ArgumentError, a_string_including("Invalid value")) | ||
| expect { nullable_setting.validate_value }.to raise_error(java.lang.IllegalArgumentException, a_string_including("Invalid value")) |
There was a problem hiding this comment.
…stead of Ruby one
…ingWithDeprecatedAlias spec test.
…when it closes the logger context
Reworked log capture in setting_with_deprecated_alias_spec to use Logger's addAppender and a spy appender implementation. This leverages the idea to don't reconfigure the Log4J with a custom build configuration, but simply adding an appender that could spy the appended lines to a logger.
…e also in runner_spec, removing the programmatic configuration way
andsel
force-pushed
the
feature/string_setting_to_java
branch
from
91e2048
to
180d597
Compare
|
💚 Build Succeeded
History
cc @andsel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Reimplements
LogStash::Setting::StringRuby setting class into theorg.logstash.settings.StringSettingand exposes it throughjava_importasLogStash::Setting::StringSetting.Updates the rspec tests in two ways:
java.lang.IllegalArgumentExceptioninstead ofArgumentErroris thrown because the kind of exception thrown by Java code, during verification.Why is it important/What is the impact to the user?
As a developer I want use Java classes to shape the configuration settings.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Author's Checklist
SPEC_OPTS="-fd -P logstash-core/spec/logstash/runner_spec.rb" ./gradlew --rerun-tasks :logstash-core:rubyTeststhere is a problem in reading the deprecation logger messages inlogstash/logstash-core/spec/logstash/runner_spec.rb
Line 269 in 467ab3f
Appenderand reconfigure logs?LogStash::String.new[ ] Renameconverting means to make explicit reference toStringSettingtoStringand use explicitjava.lang.Stringaroundjava.lang.Stringin all places inside the packageorg.logstash.settings.*.How to test this PR locally
config.field_reference.escape_styleinconfig/logstash.ymlRelated issues