Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Disregard influencers when in hard_limit #2525

Open
valeriy42 opened this issue Jun 14, 2023 · 0 comments
Open

[ML] Disregard influencers when in hard_limit #2525

valeriy42 opened this issue Jun 14, 2023 · 0 comments
Labels
>enhancement :ml

Comments

@valeriy42
Copy link
Contributor

valeriy42 commented Jun 14, 2023 •
edited
Loading

While processing the bucket data in CBucketGatherer::addEventData, we transiently fill up the queue of m_InfluencerCounts. https://github.com/elastic/ml-cpp/blob/b2e749beffff29223c3cd7dd265b3b5f7ff37bd0/lib/model/CBucketGatherer.cc#LL300C29-L300C29 When the job is hard_limit state, this can lead to temporarily using more memory than is allowed. In order to improve the stability and adherence to the memory limit, we can avoid populating this queue in the hard_limit state.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement :ml
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@valeriy42