Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massive amount of logging in output.xml #106

Open
Lakitna opened this issue Dec 20, 2023 · 0 comments
Open

Massive amount of logging in output.xml #106

Lakitna opened this issue Dec 20, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Lakitna
Copy link

Lakitna commented Dec 20, 2023

When running keywords asynchronously, a lot more output is written to output.xml.

I ran the same (decently complex) code async and sync.

Note: The comparison between the sync and async ones is far from perfect. The async versions error due to #95.

For the second one, I uncommented these lines:

ctx.output.start_keyword = lambda kw: _start_keyword(kw, built_in)
ctx.output.end_keyword = lambda kw: _end_keyword(kw, built_in)

output.xml size
async (with gevent) 4775KB
async (with gevent, removed monkey-patched log changes) 314KB
sync 646KB

That makes the async version over 7 times as big. For me, that is not workable as writing to output.xml has become a performance bottleneck in my setup.

When removing the monkey-patched logging there is a lot less logging. It makes it hard to debug, but fast to run.

It'd be great if the logging could be reduced significantly. Alternatively, it can take inspiration from the robot:flatten tag and give the user control over how much is logged.

@eldaduzman eldaduzman added enhancement New feature or request good first issue Good for newcomers labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants