Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electric,elixir-client): Write static version string to mix.exs prior to publishing #2180

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alco
Copy link
Member

@alco alco commented Dec 18, 2024

Fixes #2179

@alco alco requested a review from magnetised December 18, 2024 11:51
@icehaunter
Copy link
Contributor

I'm not against this approach, but in elixir-client it's solved just by including package.json in published filies. Maybe it's easier to just do that here too?

@magnetised
Copy link
Contributor

I solved this for the client but forgot about the top-level package. Including the package.json in the package files is a much simpler and more robust fix -- I deliberately avoided doing any source-code munging because it scares me.

if we just add files: to the package() output and include package.json there it works perfectly:

  defp package do
    [
      licenses: ["Apache-2.0"],
      links: %{
        "Electric SQL" => "https://electric-sql.com",
        "Github" => @github_repo
      },
      files: ~w(lib .formatter.exs mix.exs README.md LICENSE package.json)
    ]
  end

Copy link
Contributor

@magnetised magnetised left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my and @icehaunter's comments re package.json in package files -- feels like a more robust solution

@magnetised
Copy link
Contributor

@alco happy to finish this since I feel responsible ... 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement/bug: electric version falls back to 0.0.0 when used as hex package
3 participants