Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with windows-sign param throwing error in Electron/windows-installer (by sea-signtool) #508

Open
barkinoaa opened this issue Apr 1, 2024 · 0 comments

Comments

@barkinoaa
Copy link

barkinoaa commented Apr 1, 2024

Description

Using the windows-sign parameter in the createWindowsInstaller function of electron/windows-installer, seems to throw an error in SEA_MAIN_SCRIPT. The windows-sign parameter is added in the createWindowsInstaller function here.

However, upon inspection of the source code of the windows-sign module, it appears that it throws an error at SEA_MAIN_SCRIPT, as observed here: SEA_MAIN_SCRIPT - sea.ts. Furthermore, the error message lacks any informative details; instead, it only logs "electron-windows-sign Called with options ..." (refer to sign.ts). It was only after removing these logs that the actual error message became apparent: 'SignTool Error: File not found: windows-sign'."

This issue arises when using hookModulePath.

@barkinoaa barkinoaa changed the title Issue with windows-sign param throwing error in Electron/windows-installer (by see signtool) Issue with windows-sign param throwing error in Electron/windows-installer (by sea-signtool) Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant