Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please package src alongside the app #532

Open
iameli-streams opened this issue Sep 17, 2024 · 1 comment
Open

Please package src alongside the app #532

iameli-streams opened this issue Sep 17, 2024 · 1 comment

Comments

@iameli-streams
Copy link

I just got a really great error message:

An unhandled rejection has occurred inside Forge:
Error: Failed with exit code: 1
Output:
Attempting to build package from 'aquareum_desktop.nuspec'.
'0.1.3-41ee5c4c' is not a valid version string.
Parameter name: version
at ChildProcess.<anonymous> (/home/iameli/code/aquareum/node_modules/electron-winstaller/src/spawn-promise.ts:51:16)
    at ChildProcess.emit (node:events:520:28)
    at ChildProcess.emit (node:domain:488:12)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket.<anonymous> (node:internal/child_process:457:11)
    at Socket.emit (node:events:532:35)
    at Socket.emit (node:domain:488:12)
    at Pipe.<anonymous> (node:net:339:12)

I was like, oh cool! Source maps worked correctly, I can look at the TypeScript to see what was happening when the error happened! Except I can't, because this package doesn't publish its sources. /home/iameli/code/aquareum/node_modules/electron-winstaller/src/spawn-promise.ts does not exist. May I suggest that adding (tar cz src | wc -c ==) 6473 bytes to the distributed package would make lives a bit easier?

@iameli-streams
Copy link
Author

#533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant