Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow listening on non-0.0.0.0 interface #120

Closed
badboy opened this issue Mar 29, 2017 · 3 comments
Closed

Allow listening on non-0.0.0.0 interface #120

badboy opened this issue Mar 29, 2017 · 3 comments

Comments

@badboy
Copy link
Contributor

badboy commented Mar 29, 2017

Currently corvus always listens on 0.0.0.0, making it globally reachable over the machine's interfaces.
Additionally, the configuration parameter is called bind but sets the port corvus listens on.

It would be desirable to be able to configure the interface to listen to for incoming connection (e.g. 127.0.0.1 aka localhost only).
Redis also uses bind for the interfaces and port for the actual port it is listening to.

In addition, this would make it possible to add IPv6 support as well.

@badboy
Copy link
Contributor Author

badboy commented Mar 29, 2017

I added support for this and prelimanary IPv6 support (at least listening) in my branch here: https://github.com/badboy/corvus/tree/with-bind-and-port

@tevino
Copy link
Contributor

tevino commented Mar 30, 2017

Great idea, you are welcome to submit a PR, I did it for you, please feel free to do anything about it:
#121

@badboy
Copy link
Contributor Author

badboy commented Mar 30, 2017

I expected it to be more work initially and it will certainly affect users. But the PR is there now. Let's move discussion over there.

@badboy badboy closed this as completed Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants