Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra logout screen #2249

Closed
VolkerJunginger opened this issue Dec 19, 2023 · 5 comments
Closed

Remove extra logout screen #2249

VolkerJunginger opened this issue Dec 19, 2023 · 5 comments

Comments

@VolkerJunginger
Copy link
Contributor

Your use case

Go to setting and tap "log-out".
The app is opening an extra screen.
The user has to tap "Log-Out" again.
A pop-up is shown: "are you sure you want to logout?"

Expectation:

  • Do not show the extra screen
  • Show the pop-up right away (same as iOS)

Have you considered any alternatives?

No response

Additional context

No response

@VolkerJunginger
Copy link
Contributor Author

@amshakal Do you agree or was there any meaningfull reason to show the extra screen?

@amshakal
Copy link

I think it's fairly normal to have an 'are you sure' alert for signing out, specially in our case where signing in can mean going through the whole OIDC flow again, or worse, doing verification again. We should avoid having people sign out.

@amshakal
Copy link

I do however think that having sign out inside settings is fine but we dont need to make it prominent in the context menu on iOS

@VolkerJunginger
Copy link
Contributor Author

Ok, lets keep the alert but remove the extra page on Android.

@VolkerJunginger
Copy link
Contributor Author

Will be done w. element-hq/element-x-android#2072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants