Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show" button for image previews is too small or invisible on images with a short height #3865

Closed
MisguidedEmails opened this issue Nov 13, 2024 · 0 comments · Fixed by #3906
Assignees
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@MisguidedEmails
Copy link

Steps to reproduce

  1. Enable "Hide image & video previews" in Developer settings
  2. Send an image with quite a long width, but a short height
  3. Notice that "show" button scales with the image itself, not with the surrounding box (see screenshot)

If the image is "thin" enough, the show button isn't visible, and clicking the "surrounding" preview box does not count.

image

The image shows 3 messages, each with an image with a "taller" aspect ratio than the last. The "show" button only fills the image, not the preview box. It ranges from being invisible (thus hard to click), to it being clipped.

A practical example where this issue showed up was someone sharing a line from their terminal.

Outcome

What did you expect?

Show button to be the same size, regardless of the aspect ratio of the image.

What happened instead?

The Show button is scaled to fit the image, resulting in hard to click button. Or it not showing up at all.

Your phone model

No response

Operating system version

No response

Application version and app store

Element X Android - 0.7.3 (GitHub Release) and 0.7.2 (G-play)

Homeserver

No response

Will you send logs?

No

Are you willing to provide a PR?

No

@MisguidedEmails MisguidedEmails added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Nov 13, 2024
@bmarty bmarty self-assigned this Nov 20, 2024
@bmarty bmarty mentioned this issue Nov 20, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants