Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to decline invites without MSC3266 enabled #4224

Closed
bban160 opened this issue Jan 31, 2025 · 2 comments
Closed

Unable to decline invites without MSC3266 enabled #4224

bban160 opened this issue Jan 31, 2025 · 2 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@bban160
Copy link

bban160 commented Jan 31, 2025

Steps to reproduce

  1. Ensure experimental.msc3266_enabled is set to false in Synapse configuration (the default)
  2. Invite user to a room
  3. User tries to decline invite
  4. Nothing happens

Outcome

What did you expect?

Successfully declining the invite

What happened instead?

Nothing

Your phone model

Google Pixel 6a

Operating system version

Android 15

Application version and app store

Version 0.7.6 (40007060)

Homeserver

Synapse 1.122.0

Logs

2025-01-31T06:35:15.546123Z DEBUG matrix_sdk::http_client::native: Sending request num_attempt=1 | crates/matrix-sdk/src/http_client/native.rs:55 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]} > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s } request_id="REQ-15" method=GET uri="https://matrix.redacted/_matrix/client/unstable/im.nheko.summary/rooms/!OjJVVOWisgKQfneEjn:redacted/summary"}

2025-01-31T06:35:15.661985Z DEBUG matrix_sdk::http_client: Error while sending request: Api(Server(ClientApi(Error { status_code: 404, body: Standard { kind: Unrecognized, message: "Unrecognized request" } }))) | crates/matrix-sdk/src/http_client/mod.rs:234 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]} > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s } request_id="REQ-15" method=GET uri="https://matrix.redacted/_matrix/client/unstable/im.nheko.summary/rooms/!OjJVVOWisgKQfneEjn:redacted/summary" status=404 response_size="59 B"}

2025-01-31T06:35:15.662348Z  WARN matrix_sdk::room_preview: error when previewing room from the room summary endpoint: the server returned an error: [404 / M_UNRECOGNIZED] Unrecognized request | crates/matrix-sdk/src/room_preview.rs:158 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]}

2025-01-31T06:35:15.663062Z DEBUG matrix_sdk::http_client::native: Sending request num_attempt=1 | crates/matrix-sdk/src/http_client/native.rs:55 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]} > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s } request_id="REQ-16" method=POST uri="https://matrix.redacted/_matrix/client/v3/publicRooms" request_size="13 B"}

2025-01-31T06:35:15.738582Z DEBUG matrix_sdk::http_client: Got response | crates/matrix-sdk/src/http_client/mod.rs:230 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]} > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s } request_id="REQ-16" method=POST uri="https://matrix.redacted/_matrix/client/v3/publicRooms" request_size="13 B" status=200 response_size="388 B"}

2025-01-31T06:35:15.738951Z  WARN matrix_sdk::room_preview: Room '!OjJVVOWisgKQfneEjn:redacted' not found in room directory search. | crates/matrix-sdk/src/room_preview.rs:165 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]}

2025-01-31T06:35:15.739275Z DEBUG matrix_sdk::http_client::native: Sending request num_attempt=1 | crates/matrix-sdk/src/http_client/native.rs:55 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]} > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s } request_id="REQ-17" method=GET uri="https://matrix.redacted/_matrix/client/v3/rooms/!OjJVVOWisgKQfneEjn:redacted/state"}

2025-01-31T06:35:15.740179Z DEBUG matrix_sdk::http_client::native: Sending request num_attempt=1 | crates/matrix-sdk/src/http_client/native.rs:55 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]} > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s } request_id="REQ-18" method=GET uri="https://matrix.redacted/_matrix/client/v3/rooms/!OjJVVOWisgKQfneEjn:redacted/joined_members"}

2025-01-31T06:35:15.806411Z DEBUG matrix_sdk::http_client: Error while sending request: Api(Server(ClientApi(Error { status_code: 403, body: Standard { kind: Forbidden { authenticate: None }, message: "User @username:redacted not in room !OjJVVOWisgKQfneEjn:redacted, and room previews are disabled" } }))) | crates/matrix-sdk/src/http_client/mod.rs:234 | spans: from_not_joined{room_id="!OjJVVOWisgKQfneEjn:redacted" room_or_alias_id="!OjJVVOWisgKQfneEjn:redacted" via=["redacted"]} > send{server_versions=[V1_0, V1_1, V1_2, V1_3, V1_4, V1_5, V1_6, V1_7, V1_8, V1_9, V1_10, V1_11] config=RequestConfig { timeout: 30s } request_id="REQ-17" method=GET uri="https://matrix.redacted/_matrix/client/v3/rooms/!OjJVVOWisgKQfneEjn:redacted/state" status=403 response_size="157 B"}

2025-01-31T06:35:15.812895Z ERROR elementx: Failed to get pending room for !OjJVVOWisgKQfneEjn:redacted

org.matrix.rustcomponents.sdk.ClientException$Generic: msg=the server returned an error: [403 / M_FORBIDDEN] User @username:redacted not in room !OjJVVOWisgKQfneEjn:redacted, and room previews are disabled
	at org.matrix.rustcomponents.sdk.FfiConverterTypeClientError.read(SourceFile:26)
	at org.matrix.rustcomponents.sdk.FfiConverterRustBuffer$DefaultImpls.liftFromRustBuffer(SourceFile:13)
	at org.matrix.rustcomponents.sdk.FfiConverterTypeClientError.liftFromRustBuffer(SourceFile:1)
	at org.matrix.rustcomponents.sdk.FfiConverterRustBuffer$DefaultImpls.lift(SourceFile:6)
	at org.matrix.rustcomponents.sdk.ClientException$ErrorHandler.lift(SourceFile:8)
	at org.matrix.rustcomponents.sdk.Matrix_sdk_ffiKt.access$uniffiCheckCallStatus(SourceFile:123)
	at org.matrix.rustcomponents.sdk.Matrix_sdk_ffiKt.uniffiRustCallAsync(SourceFile:194)
	at org.matrix.rustcomponents.sdk.Matrix_sdk_ffiKt$uniffiRustCallAsync$1.invokeSuspend(Unknown Source:17)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(SourceFile:9)
	at kotlinx.coroutines.DispatchedTask.run(SourceFile:107)
	at com.google.android.gms.tasks.zzc.run(SourceFile:49)
	at kotlinx.coroutines.scheduling.TaskImpl.run(SourceFile:3)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(SourceFile:93)
 | 

See also the similar, but not exactly the same, issue in Element X iOS which contains more context for this bug: element-hq/element-x-ios#3713

@bban160 bban160 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Jan 31, 2025
@manuroe
Copy link
Member

manuroe commented Jan 31, 2025

Hi @bban160. Simillar answer as element-hq/element-x-ios#3713: EX depends on Room Summary API. It is mandatory to have it on the associated homeserver. This API is required to have a nicer app UX.

@manuroe manuroe closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025
@bban160
Copy link
Author

bban160 commented Jan 31, 2025

Hi @manuroe, I understand your stance, but I would rather avoid enabling this experimental API. I am only asking for Element X to fail gracefully when the Room Summary API is not enabled, and in these particular cases I do not see why the Room Summary API is being invoked at all as the user has already chosen an action based on the information presented.

I am not trying to deny that the Room Summary API has valid usecases in Element X and should be used when available and appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

2 participants