Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count of people besides the People room settings entry is incorrect after joining room #4238

Open
dkasak opened this issue Feb 6, 2025 · 3 comments
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@dkasak
Copy link
Member

dkasak commented Feb 6, 2025

Steps to reproduce

Immediately upon joining a room, the count of people besides People in room settings can be wrong. Actually entering the People menu shows the correct member list, but the count outside is wrong until the app is restarted.

Image

In the above situation there were actually 7 people in the room. Unfortunately I didn't reproduce this myself and the affected person cannot rageshake so there will be no logs.

Outcome

What did you expect?

The correct count to be displayed.

What happened instead?

The incorrect count was displayed.

Your phone model

Samsung Galaxy A54 5G

Operating system version

Android 14

Application version and app store

Element X 0.7.6

Homeserver

matrix.org

Will you send logs?

No

Are you willing to provide a PR?

No

@dkasak dkasak added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Feb 6, 2025
@dkasak dkasak changed the title Count of people besides People room settings entry is incorrect after joining room Count of people besides the People room settings entry is incorrect after joining room Feb 6, 2025
@frebib
Copy link
Contributor

frebib commented Feb 6, 2025

I wonder if this is related to/caused by the same thing as #4236

@frebib
Copy link
Contributor

frebib commented Feb 6, 2025

Maybe tangentially, I do think it would be prudent for the app to render some kind of indication that the user count in the room is unknown (spinner, or ?, or something) until the join is complete and the full state of the room is resolved on the homeserver

@jmartinesp
Copy link
Member

Maybe tangentially, I do think it would be prudent for the app to render some kind of indication that the user count in the room is unknown (spinner, or ?, or something) until the join is complete and the full state of the room is resolved on the homeserver

I don't think so, the value we use there comes from a completely different source, AFAICT. And if I'm not mistaken, this value is only updated here when we receive the room from sliding sync, then it's serialized and deserialized when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

No branches or pull requests

3 participants