Fix build errors and broken snapshot tests

Author: stefanceriu

ElementX/Sources/Other/Extensions/String.swift

@@ -100,10 +100,8 @@ extension String {
 
 extension String {
     static func makeCanonicalAlias(aliasLocalPart: Self?, serverName: Self?) -> Self? {
-        guard let aliasLocalPart = aliasLocalPart,
-              !aliasLocalPart.isEmpty,
-              let serverName = serverName,
-              !serverName.isEmpty else {
+        guard let aliasLocalPart, !aliasLocalPart.isEmpty,
+              let serverName, !serverName.isEmpty else {
             return nil
         }
         return "#\(aliasLocalPart):\(serverName)"

ElementX/Sources/Screens/CreateRoom/CreateRoomModels.swift

@@ -72,3 +72,14 @@ enum CreateRoomAliasErrorState {
     case alreadyExists
     case invalidSymbols
 }
+
+extension Set<CreateRoomAliasErrorState> {
+    var errorDescription: String? {
+        if contains(.alreadyExists) {
+            return L10n.errorRoomAddressAlreadyExists
+        } else if contains(.invalidSymbols) {
+            return L10n.errorRoomAddressInvalidSymbols
+        }
+        return nil
+    }
+}

ElementX/Sources/Screens/EditRoomAddressScreen/View/EditRoomAddressScreen.swift

@@ -91,11 +91,17 @@ struct EditRoomAddressScreen_Previews: PreviewProvider, TestablePreview {
         NavigationStack {
             EditRoomAddressScreen(context: invalidSymbolsViewModel.context)
         }
+        .snapshotPreferences(expect: invalidSymbolsViewModel.context.$viewState.map { state in
+            !state.aliasErrors.isEmpty
+        })
         .previewDisplayName("Invalid symbols")
 
         NavigationStack {
             EditRoomAddressScreen(context: alreadyExistingViewModel.context)
         }
+        .snapshotPreferences(expect: alreadyExistingViewModel.context.$viewState.map { state in
+            !state.aliasErrors.isEmpty
+        })
         .previewDisplayName("Already existing")
     }
 }

ElementX/Sources/Screens/SecurityAndPrivacyScreen/View/SecurityAndPrivacyScreen.swift

@@ -212,6 +212,9 @@ struct SecurityAndPrivacyScreen_Previews: PreviewProvider, TestablePreview {
         NavigationStack {
             SecurityAndPrivacyScreen(context: publicViewModel.context)
         }
+        .snapshotPreferences(expect: publicViewModel.context.$viewState.map { state in
+            state.currentSettings.isVisibileInRoomDirectory == true
+        })
         .previewDisplayName("Public room")
 
         NavigationStack {
@@ -222,6 +225,9 @@ struct SecurityAndPrivacyScreen_Previews: PreviewProvider, TestablePreview {
         NavigationStack {
             SecurityAndPrivacyScreen(context: restrictedViewModel.context)
         }
+        .snapshotPreferences(expect: restrictedViewModel.context.$viewState.map { state in
+            state.currentSettings.isVisibileInRoomDirectory == true
+        })
         .previewDisplayName("Restricted room")
     }
 }