Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance CI missing real word regressions #2073

Open
neilisfragile opened this issue Nov 13, 2023 · 1 comment
Open

Performance CI missing real word regressions #2073

neilisfragile opened this issue Nov 13, 2023 · 1 comment
Labels
A-Performance T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@neilisfragile
Copy link
Member

Is your feature request related to a problem? Please describe.

We use automated performance testing to track for regressions in Element X. These tests must be comprehensive to build confidence that the app is not slowing down as we add more functionality.

Describe the solution you'd like
I would like https://vector-im.github.io/element-x-ios/performance/ to be able to detect bugs like #2062 ahead of time. Or at the very least understand the failure mode to know why it is not possible.

@pixlwave
Copy link
Member

pixlwave commented Nov 13, 2023

A first guess at this given Matthew's hunch about key backups, the tests only sign in and log out. The client is never verified (so presumably backups aren't involved) and we never perform a subsequent launch verified or otherwise. Not sure how we would automate cross-signing with the current setup. Maybe these performance tests would be better to live in trafficlight (which I think supports multiple devices and so could cross-sign)?

@stefanceriu stefanceriu added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Performance T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

4 participants