Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User mention selection only works at the end of text in the compositor #3522

Open
Jaffex opened this issue Nov 16, 2024 · 4 comments
Open

User mention selection only works at the end of text in the compositor #3522

Jaffex opened this issue Nov 16, 2024 · 4 comments
Labels
A-Pills good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@Jaffex
Copy link

Jaffex commented Nov 16, 2024

Steps to reproduce

When composing a message, write some text, then try to add a mention anywhere in between the text by starting with an @ sign and the beginning of a user's name.

Outcome

What did you expect?

I would expect the @ and any given text after it right to the current cursor position to act exactly as it would act at the end of a given message in the compositor, by suggesting users that start with the already typed text.

After selecting a user, I would expect a space after inserting the user pill if there is not already one after the cursor.

What happened instead?

If you try to mention another user from within anywhere within the text, the user selection does not open at all.
It only works if you're at the end of the text within the compositor.

Here's a little example:

screenrecording.mp4

Your phone model

iPhone 12 mini

Operating system version

iOS 18.1

Application version

1.9.5 (136)

Homeserver

irrelevant

Will you send logs?

Yes

@Jaffex Jaffex changed the title User mentions only work at the end of text in the compositor User mention selection only works at the end of text in the compositor Nov 16, 2024
@Velin92 Velin92 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely A-Pills labels Dec 2, 2024
@vickcoo
Copy link

vickcoo commented Jan 22, 2025

Could I work on this issue? This would be my first contribution in Element 😊

@stefanceriu
Copy link
Member

That would be lovely, thank you!

@stefanceriu stefanceriu added the good first issue Good for newcomers label Jan 22, 2025
@vickcoo
Copy link

vickcoo commented Jan 22, 2025

How should I test this part? I need detail to know the workflow for my first time in this project.

Here is my understanding now

  1. edit the target ElementX
  2. checked scheme UI_TESTS_SCREEN and set screen id
  3. run

It sounds like a silly question, but I really need know 🫨

@stefanceriu
Copy link
Member

That works but what you might actually want are the CompletionSuggestionServiceTests unit tests and processTextMessage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Pills good first issue Good for newcomers O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants