Bust _membership_stream_cache cache when current state changes
#17368
Comments
3 tasks
MadLittleMods
added a commit
that referenced
this issue
Sep 18, 2024
3 tasks
MadLittleMods
added a commit
that referenced
this issue
Jan 8, 2025
) This is particularly a problem in a state reset scenario where the membership might change without a corresponding event. This PR is targeting a scenario where a state reset happens which causes room membership to change. Previously, the cache would just hold onto stale data and now we properly bust the cache in this scenario. We have a few tests for these scenarios which you can see are now fixed because we can remove the `FIXME` where we were previously manually busting the cache in the test itself. This is a general Synapse thing so by it's nature it helps out Sliding Sync. Fix #17368 Prerequisite for #17929 --- Match when are busting `_curr_state_delta_stream_cache`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spawning from #17320 (comment)
Bust
_membership_stream_cachecache when current state changes.Currently, the only reference I can find is in
CacheInvalidationWorkerStore._invalidate_caches_for_event(...)which doesn't handle current state changing.Dev notes
This is where we should be adding the cache busting:
synapse/synapse/storage/databases/main/cache.py
Line 266 in 956f20e
The text was updated successfully, but these errors were encountered: