return in finally swallows exceptions

[iritkatriel]

In

elementary/elementary/cli/cli.py

Line 30 in 1f4e91c

return os.path.join(target_path, "edr.log")

there is a return statement in a finally block, which would swallow any in-flight exception.

This means that if an unhandled exception (including a BaseException such as KeyboardInterrupt) is raised from the try body, or any exception is raised from an except: clause, it will not propagate on as expected.

If it was the intention to swallow all exceptions here, I would suggest to do this explicitly with except BaseExceptions: to make the intention clear.

See also https://docs.python.org/3/tutorial/errors.html#defining-clean-up-actions.