Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELE-62] Add dbt source freshness results into Test Results and Test Runs tabs in report UI #450

Closed
ivan-toriya opened this issue Dec 2, 2022 · 13 comments

Comments

@ivan-toriya
Copy link
Contributor

ivan-toriya commented Dec 2, 2022

Is your feature request related to a problem? Please describe.
I want to see the overview and history of dbt source freshness results

Describe the solution you'd like
dbt source freshness results listed in Test Results and Test Runs tabs in report UI

Describe alternatives you've considered
Only have them as alerts in Slack. (current implementation)

Additional context
None

Would you be willing to contribute this feature?
Yes

ELE-62

@Hadarsagiv Hadarsagiv changed the title Add dbt source freshness results into Test Results and Test Runs tabs in report UI [ELE-62] Add dbt source freshness results into Test Results and Test Runs tabs in report UI Jan 3, 2023
@elongl
Copy link
Member

elongl commented Feb 1, 2023

We can begin working on this again now that there's edr run-operation upload-source-freshness.

@Hadarsagiv Hadarsagiv added Community Created by Linear-GitHub Sync and removed Community Created by Linear-GitHub Sync labels Feb 1, 2023
@IDoneShaveIt IDoneShaveIt removed their assignment Apr 25, 2023
@christopherekfeldt
Copy link

Yes would be great if the "Freshness" GUI in the report would display the results of the "dbt source freshness" runs as well as the elementary.anomalies.freshness tests.

@benoit-tropos-io
Copy link
Contributor

Yes would be super great. We already have 3 huge projects that are desperately asking for this feature.

@shyamk136
Copy link

+1 on this feature. The Freshness Anomaly test is great for viewing trends over time but a simple 'freshness' result based on the timing helps the report viewer understand if there is any immediate issue that needs action.

@fredmny
Copy link
Contributor

fredmny commented Jul 4, 2023

Just +1'ing this. It would be really awesome.

@harukitake
Copy link

harukitake commented Jul 10, 2023

+1. I really hope this feature.

@viniciusnunest
Copy link

+1 .

@paritoshg2010
Copy link

+1, Looking forward to this feature :)

@Maayan-s
Copy link
Contributor

Hey all,
We are finally implementing this!
This is the current design, would be great to get your feedback on it before we start developing:

https://www.figma.com/file/OX8pEefdDd2zBTGhzpzywl/Source-freshness-visualization-Pr[…]tary)?type=design&node-id=0-1&mode=design&t=as6eoYaEfc71CIXU-0

@ivan-toriya @paritoshg2010 @viniciusnunest @harukitake @fredmny @shyamk136 @benoit-tropos-io @christopherekfeldt

@viniciusnunest
Copy link

viniciusnunest commented Aug 30, 2023

@Maayan-s Your design for indicating source freshness on the test page is excellent. Will similar features be incorporated into the main dashboard as well? like a indicator ..

@Maayan-s
Copy link
Contributor

@viniciusnunest thanks!
First step is to add the results to the freshness tile in the dashboard:
image

What kind of indicator did you have in mind?

@viniciusnunest
Copy link

viniciusnunest commented Aug 30, 2023

Just that and the history at the bottom of the dashboard as we have tests would be very good, as this is something related to the source, this distinction would be very nice to give visibility

Like this :
image

And have a space in the second line of tiles, what do you think?
image

@fredmny
Copy link
Contributor

fredmny commented Sep 12, 2023

@Maayan-s Coming a little late since I was on vacation, but I quietly celebrated when I saw the the notification for your message on my phone as soon as you posted it.

I really like the design. It's way better than I expected! I would +1 the request for a KPI-like indicator on the main dashboard, like the image you sent afterwards. And adding to this better differentiate the source freshness indicator from the source freshness anomalies one (but I think this is a given with this implementation).

Thanks for the great work once again

@Maayan-s Maayan-s closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests