Skip to content

Commit 99d88a3

Browse files
committed
Fix spec for display_name/2. Closes #43
1 parent b53f859 commit 99d88a3

File tree

5 files changed

+20
-3
lines changed

5 files changed

+20
-3
lines changed

CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# Changelog
22

3+
## Cldr_Units v3.16.5
4+
5+
This is the changelog for Cldr_units v3.16.4 released on April 11th, 2024. For older changelogs please consult the release tag on [GitHub](https://github.com/elixir-cldr/cldr_units/tags)
6+
7+
### Bug Fixes
8+
9+
* Fix spec for `Cldr.Unit.display_name/2`. Thanks to @ryotsu for the report. Closes #43.
10+
311
## Cldr_Units v3.16.4
412

513
This is the changelog for Cldr_units v3.16.4 released on November 2nd, 2023. For older changelogs please consult the release tag on [GitHub](https://github.com/elixir-cldr/cldr_units/tags)

lib/cldr/unit.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -1604,7 +1604,7 @@ defmodule Cldr.Unit do
16041604
"l"
16051605
16061606
"""
1607-
@spec display_name(Cldr.Unit.value() | Cldr.Unit.t(), Keyword.t()) ::
1607+
@spec display_name(translatable_unit() | t(), Keyword.t()) ::
16081608
String.t() | {:error, {module, binary}}
16091609

16101610
def display_name(unit, options \\ [])

lib/cldr/unit/backend.ex

+1-1
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ defmodule Cldr.Unit.Backend do
413413
"l"
414414
415415
"""
416-
@spec display_name(Cldr.Unit.value() | Cldr.Unit.t(), Keyword.t()) ::
416+
@spec display_name(Cldr.Unit.translatable_unit() | Cldr.Unit.t(), Keyword.t()) ::
417417
String.t() | {:error, {module, binary}}
418418

419419
def display_name(unit, options \\ []) do

mix.exs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
defmodule Cldr.Units.Mixfile do
22
use Mix.Project
33

4-
@version "3.16.4"
4+
@version "3.16.5"
55

66
def project do
77
[

mix/for_dialyzer.ex

+9
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
defmodule Cldr.Unit.Dialyzer do
2+
def display_name do
3+
MyApp.Cldr.Unit.display_name(:kilogram)
4+
MyApp.Cldr.Unit.display_name(Cldr.Unit.new!(:foot, 1))
5+
6+
Cldr.Unit.display_name(:kilogram, backend: MyApp.Cldr)
7+
Cldr.Unit.display_name(Cldr.Unit.new!(:foot, 1), backend: MyApp.Cldr)
8+
end
9+
end

0 commit comments

Comments
 (0)