Even more helpful message

Author: benkimpel

lib/myxql/protocol/values.ex

@@ -131,7 +131,7 @@ defmodule MyXQL.Protocol.Values do
   def decode_text_value(value, type) when type in [:float, :double] do
     case Float.parse(value) do
       {value, ""} -> value
-      _ -> raise ArgumentError, "cannot parse float/double"
+      _ -> raise ArgumentError, ~s(cannot decode text value "#{value}" to float/double)
     end
   end
 

test/myxql/protocol/values_test.exs

@@ -94,11 +94,11 @@ defmodule MyXQL.Protocol.ValueTest do
         assert Float.round(insert_and_get(c, "my_unsigned_float", 10.0), 2) == 10.0
         assert Float.round(insert_and_get(c, "my_unsigned_float", 13.37), 2) == 13.37
 
-        assert_raise ArgumentError, ~r"cannot parse float/double", fn ->
+        assert_raise ArgumentError, ~s(cannot decode text value "10.0ABC" to float/double), fn ->
           MyXQL.Protocol.Values.decode_text_value("10.0ABC", :float)
         end
 
-        assert_raise ArgumentError, ~r"cannot parse float/double", fn ->
+        assert_raise ArgumentError, ~s(cannot decode text value "ABC" to float/double), fn ->
           MyXQL.Protocol.Values.decode_text_value("ABC", :float)
         end
       end
@@ -111,11 +111,11 @@ defmodule MyXQL.Protocol.ValueTest do
         assert_roundtrip(c, "my_unsigned_double", 10.0)
         assert_roundtrip(c, "my_unsigned_double", 13.37)
 
-        assert_raise ArgumentError, ~r"cannot parse float/double", fn ->
-          MyXQL.Protocol.Values.decode_text_value("10.0.ABC", :float)
+        assert_raise ArgumentError, ~s(cannot decode text value "10.0ABC" to float/double), fn ->
+          MyXQL.Protocol.Values.decode_text_value("10.0ABC", :float)
         end
 
-        assert_raise ArgumentError, ~r"cannot parse float/double", fn ->
+        assert_raise ArgumentError, ~s(cannot decode text value "ABC" to float/double), fn ->
           MyXQL.Protocol.Values.decode_text_value("ABC", :float)
         end
       end