Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python 3.10 compatibility issues #55

Closed
wants to merge 2 commits into from
Closed

Fix Python 3.10 compatibility issues #55

wants to merge 2 commits into from

Conversation

tirkarthi
Copy link

Fixes #50 . Deprecated unittest aliases have been removed in Python 3.11. This changes assertEquals to assertEqual to fix that.

raf64flo
raf64flo approved these changes Jan 21, 2022
View reviewed changes
Copy link
Collaborator

@raf64flo raf64flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@raf64flo
Copy link
Collaborator

Thanks for the PR @tirkarthi 👍

@cpommier
Copy link
Member

fixed in !58, thanks again

@cpommier cpommier closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raf64flo raf64flo raf64flo approved these changes

Assignees

@cpommier cpommier

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: 'Thread' object has no attribute 'isAlive'. Did you mean: 'is_alive'?
3 participants
@tirkarthi @raf64flo @cpommier