Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Residual use of ami from #53 #66

Closed
sciatro opened this issue Apr 22, 2023 · 1 comment
Closed

Residual use of ami from #53 #66

sciatro opened this issue Apr 22, 2023 · 1 comment
Assignees
Milestone

Comments

@sciatro
Copy link

sciatro commented Apr 22, 2023

The code group weights continue to refer to Acute MI (ami) vs the MI (mi) name change made to the codes in #53.

It looks like this is the case because 92d59b7 touched make-mapping.R only vs. 6c1dac2 which touched both make-mapping.R and make-weights.R

I just happened to notice it in passing while tracking down an unexpected result that ultimately turned out to be the sub tree grepping described in #9. It is not obvious to me that this impacts function as it seems like weights are applied by order, not name, but it's easy to imagine confusion arising.

@ellessenne
Copy link
Owner

Good catch, thanks for pointing this out - I will fix this for the next release!

@ellessenne ellessenne self-assigned this Apr 25, 2023
@ellessenne ellessenne added this to the 1.0.6 milestone Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants