Added HHVM 3.18 as a test target.

Author: ezzatron

.travis.yml

@@ -25,7 +25,11 @@ matrix:
           sudo: required
           dist: trusty
           group: edge
-        - php: hhvm-3.15
+        - php: hhvm-3.18
+          sudo: required
+          dist: trusty
+          group: edge
+        - php: hhvm-3.18
           sudo: required
           dist: trusty
           group: edge

test/bin/hhvm renamed to test/bin/hhvm-3.12

@@ -3,4 +3,4 @@ docker run -it --rm \
     -v "${PWD}:/usr/src/phony" \
     -w /usr/src/phony \
     -e "PATH=vendor/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" \
-    hhvm/hhvm "$@"
+    hhvm/hhvm:3.12-lts-latest "$@"

test/bin/hhvm-3.15

@@ -0,0 +1,6 @@
+#!/bin/sh
+docker run -it --rm \
+    -v "${PWD}:/usr/src/phony" \
+    -w /usr/src/phony \
+    -e "PATH=vendor/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" \
+    hhvm/hhvm:3.15-lts-latest "$@"

test/bin/hhvm-3.18

@@ -0,0 +1,6 @@
+#!/bin/sh
+docker run -it --rm \
+    -v "${PWD}:/usr/src/phony" \
+    -w /usr/src/phony \
+    -e "PATH=vendor/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin" \
+    hhvm/hhvm:3.18-lts-latest "$@"

test/fixture/feature-detector/features.json

@@ -29,7 +29,7 @@
     "Can use a constant as a parameter default value":                              ["parameter.default.constant",                  "5.4.6.x", "999",   [], "3.13.x", "999", []],
     "Can override a method that uses self as a type hint":                          ["parameter.type.self.override",                "5.4.1.x", "999",   [], "0.x",    "999", []],
     "Can use variadic parameters":                                                  ["parameter.variadic",                          "5.6.x",   "999",   [], "3.3.x",  "999", []],
-    "Can use by-reference variadic parameters":                                     ["parameter.variadic.reference",                "5.6.x",   "999",   [], "999",    "0.x", []],
+    "Can use by-reference variadic parameters":                                     ["parameter.variadic.reference",                "5.6.x",   "999",   [], "3.17.x", "999", []],
     "Can use type hints with variadic parameters":                                  ["parameter.variadic.type",                     "5.6.x",   "999",   [], "999",    "0.x", []],
     "Can use scalar type hints":                                                    ["parameter.hint.scalar",                       "7.x",     "999",   [], "3.11.x", "999", []],
     "Language keywords can be used as method names":                                ["parser.relaxed-keywords",                     "7.x",     "999",   [], "999",    "0.x", []],

test/suite/FunctionalTest.php

@@ -128,8 +128,8 @@ function () {
 
     public function testVariadicParameterMockingWithType()
     {
-        if (!$this->featureDetector->isSupported('parameter.variadic')) {
-            $this->markTestSkipped('Requires variadic parameters.');
+        if (!$this->featureDetector->isSupported('parameter.variadic.type')) {
+            $this->markTestSkipped('Requires type-hinted variadic parameters.');
         }
         if ($this->featureDetector->isSupported('runtime.hhvm')) {
             $this->markTestSkipped('Broken because of https://github.com/facebook/hhvm/issues/5762');