Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Delete" considered harmful, change to "Lock" or remove entirely? #345

Open
myself248 opened this issue Jan 14, 2015 · 2 comments
Open

"Delete" considered harmful, change to "Lock" or remove entirely? #345

myself248 opened this issue Jan 14, 2015 · 2 comments
Milestone

Comments

@myself248
Copy link

i3Detroit's instance has just suffered another data problem apparently caused by inappropriate use of the Delete button. (Member record deleted instead of setting a plan end date.) I'm starting to think there are no appropriate uses, and the function should be removed. I think #344 is about fixing the delete function, but instead of giving it additional functionality (which is closely tied to business logic about how to handle payments, etc), I'm opening this issue as an alternate solution -- it would be easier and better to simply remove the delete function.

@elplatt
Copy link
Owner

elplatt commented Jan 14, 2015

A good solution might be to add a "deleted" datetime to each table and add
a "is null" check to all of the select queries. Then to delete we'd just
set the delete datetime. If we needed to go back and review or undelete it
would be easy to do that through sql.

On Wed, Jan 14, 2015 at 11:11 AM, myself248 notifications@github.com
wrote:

i3Detroit's instance has just suffered another data problem apparently
caused by inappropriate use of the Delete button. (Member record deleted
instead of setting a plan end date.) I'm starting to think there are no
appropriate uses, and the function should be removed. I think #344
#344 is about fixing the
delete function, but instead of giving it additional functionality (which
is closely tied to business logic about how to handle payments, etc), I'm
opening this issue as an alternate solution -- it would be easier and
better to simply remove the delete function.


Reply to this email directly or view it on GitHub
#345.

Edward L. Platt
http://elplatt.com
http://civic.mit.edu/users/elplatt
http://i3detroit.com
@elplatt http://twitter.com/elplatt

This electronic mail message was sent from my desktop personal computer.
Please forgive any long-winded, overly-prosaic ramblings.

@mjgardes
Copy link

I like it. It would be nice to have a reason for deletion text column too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants