Skip to content

Fix null reference and typo in shell feature provider #7286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 2 commits into from
Feb 12, 2026
Merged

Fix null reference and typo in shell feature provider #7286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be9b00a
Initial plan
Copilot Feb 11, 2026
d65dbfc
Fix null StartupType guard in Find() and typo in variable descriptor
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/common/Elsa.Features/Services/ShellInstalledFeatureProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ public IEnumerable<FeatureDescriptor> List()
/// <inheritdoc />
public FeatureDescriptor? Find(string fullName)
{
var shellFeature = _shellFeatures.FirstOrDefault(sf =>
MapToFullName(sf) == fullName);
var shellFeature = _shellFeatures
.Where(sf => sf.StartupType != null)
.FirstOrDefault(sf => MapToFullName(sf) == fullName);

return shellFeature != null ? MapToElsaFeatureDescriptor(shellFeature) : null;
}
Expand Down
2 changes: 1 addition & 1 deletion src/modules/Elsa.Workflows.Management/ShellFeatures/WorkflowManagementFeature.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public class WorkflowManagementFeature : IShellFeature
/// </summary>
public HashSet<VariableDescriptor> VariableDescriptors { get; } =
[
new(typeof(object), PrimitivesCategory, "The root class for all object in the CLR System."),
new(typeof(object), PrimitivesCategory, "The root class for all objects in the CLR System."),
new(typeof(string), PrimitivesCategory, "Represents a static string of characters."),
new(typeof(bool), PrimitivesCategory, "Represents a true or false value."),
new(typeof(int), PrimitivesCategory, "A 32 bit integer."),
Expand Down