Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create mini dataset for tests of functions that use bwtools #69

Open
cnluzon opened this issue Aug 12, 2020 · 0 comments
Open

Create mini dataset for tests of functions that use bwtools #69

cnluzon opened this issue Aug 12, 2020 · 0 comments

Comments

@cnluzon
Copy link
Collaborator

cnluzon commented Aug 12, 2020

Right now test_bwplot and test_bwtools use some sort of mix between hard-coding some objects in test_bwtools files and and importing some bigWig / BED files that are deployed with the package in inst/ with bwtools functions for test_bwplot. Plus some mocking to avoid doing this for every function, which would be very slow.

A better solution could be include some RData that can be imported in the tests. Specially for test_bwplot and other things we may add in the future to handle outputs for bwtools functions.

In test_bwtools I'd still keep some degree of hard-coding, because it's then more visible where is the error if some test case crashes, and it becomes easier to add more tests if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant