Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ember Octane #103

Open
lvegerano opened this issue Aug 12, 2019 · 6 comments
Open

Ember Octane #103

lvegerano opened this issue Aug 12, 2019 · 6 comments

Comments

@lvegerano
Copy link

Are there any plans of supporting Octane/glimmer components?
@lvegerano lvegerano changed the title ember Octane Ember Octane Aug 12, 2019
@elwayman02
Copy link
Owner

@lvegerano I haven't made specific plans for this, but that's a great idea! If anyone wants to drop some thoughts in here about how to do that (likely a decorator?), we can use this issue as a starting point.

@lvegerano
Copy link
Author

A decorator would work the only issue I see so far is the willInsertElement method. Glimmer components don't have this hook.

@lvegerano lvegerano reopened this Aug 28, 2019
@elwayman02
Copy link
Owner

elwayman02 commented Sep 17, 2019 •
edited
Loading

SPENCER SAYS THIS SHOULD BE A MODIFIER ⛺

@lvegerano
Copy link
Author

🤷‍♂ Still run into some of the same issues. One particular would be tracking component counts. Glimmer components don't have a unique id (not that I was able to find) they would have to be tagged by the lib somehow.

@NullVoxPopuli
Copy link

modifier or decorator? o.o maybe both? let the user choose? :D

@elwayman02
Copy link
Owner

I wonder if we could use PerformanceObserver...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NullVoxPopuli @elwayman02 @lvegerano