Merge pull request #225 from gorner/bugfix/deprecate-syntax

[bugfix] Fix Ember.deprecate syntax

Author: elwayman02

addon-test-support/only.js

@@ -6,8 +6,10 @@ import { wrapTest, commonConfig } from './utils/config';
 commonConfig();
 
 export default function only(testName, callback) {
-  deprecate('This pattern is now deprecated. Please import the `setupSinon` method instead.', {
-    id: 'ember-sinon-qunit.only'
+  deprecate('This pattern is now deprecated. Please import the `setupSinon` method instead.', false, {
+    id: 'ember-sinon-qunit.only',
+    until: '5.0.0',
+    url: 'https://github.com/elwayman02/ember-sinon-qunit#migration-from-older-versions-of-ember-sinon-qunit'
   });
   wrapTest(testName, callback, emberQUnitOnly);
 }

addon-test-support/test.js

@@ -6,8 +6,10 @@ import { wrapTest, commonConfig } from './utils/config';
 commonConfig();
 
 export default function test(testName, callback) {
-  deprecate('This pattern is now deprecated. Please import the `setupSinon` method instead.', {
-    id: 'ember-sinon-qunit.test'
+  deprecate('This pattern is now deprecated. Please import the `setupSinon` method instead.', false, {
+    id: 'ember-sinon-qunit.test',
+    until: '5.0.0',
+    url: 'https://github.com/elwayman02/ember-sinon-qunit#migration-from-older-versions-of-ember-sinon-qunit'
   });
   wrapTest(testName, callback, emberQUnitTest);
 }

tests/unit/ember-sinon-qunit-test.js

@@ -2,6 +2,8 @@ import { module } from 'qunit';
 import { resolve } from 'rsvp';
 import test from 'ember-sinon-qunit/test-support/test';
 import assertSinonInTestContext from '../helpers/assert-sinon-in-test-context';
+import Ember from 'ember';
+import sinon from 'sinon';
 
 let fooValue = 42;
 let origMethod;
@@ -24,10 +26,21 @@ module('Deprecated | Unit | ember-sinon-qunit', {
 
 assertSinonInTestContext(test);
 
+const deprecateStub = sinon.stub(Ember, 'deprecate').callsFake(function (unused, deprecateTest) {
+  if (deprecateTest !== false) {
+    throw new Error('Ember.deprecate should be called with 2nd argument `false`');
+  }
+});
+
 test('does not destroy context from beforeEach', function (assert) {
   assert.equal(this.foo, fooValue);
 });
 
+if (!deprecateStub.called) {
+  throw new Error('Ember.deprecate should be called');
+}
+deprecateStub.restore();
+
 test('async with assert.async()', function (assert) {
   assert.expect(2);
   this.stub(obj, 'method');