Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI/CD - Add publish *.yml gh-actions config #101

Closed
elycruz opened this issue Aug 31, 2022 · 1 comment
Closed

CI/CD - Add publish *.yml gh-actions config #101

elycruz opened this issue Aug 31, 2022 · 1 comment
Assignees
@elycruz
Labels
enhancement

Comments

@elycruz
Copy link
Owner

elycruz commented Aug 31, 2022 •
edited
Loading

Acceptance Criteria

Add a publish-master.yml github actions file to ensure 'publish', for the package, only happens after github actions CI/CD tasks have passed.
@elycruz elycruz self-assigned this Aug 31, 2022
elycruz added a commit that referenced this issue Aug 31, 2022
@elycruz
issue-#101 - Added 'publish-master.yml' file.
70e5ac3
elycruz added a commit that referenced this issue Aug 31, 2022
@elycruz
issue-#101 - Updated node versions in 'dev-build-and-test' github wor…
ed05406 
…kflow file.
elycruz added a commit that referenced this issue Aug 31, 2022
@elycruz
issue-#101 - Added 'CODEOWNERS' file (files docs located in github do…
3e60ded 
…cs.).
elycruz added a commit that referenced this issue Aug 31, 2022
@elycruz
issue-#101 - Changed access token names in 'publish*' workflow file.
e75dfac
elycruz added a commit that referenced this issue Aug 31, 2022
@elycruz
issue-#101 - Removed unrequired 'UNALLOCATED_TODOS.md' file.
93bd881
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Updated './.circleci/config.yml' to use node 14, docker …
82ed593 
…image, for it's tests.
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Formatted '.gitignore', and '.npmignore'.
9baa4d6 
- Added './dist', and, './ts3.5' dirs. to './.gitignore'.
- Added 'MAINTAINERS.md'.
- Replaced 'contributors' with 'maintainers' field, in './package.json'.
- Removed some whitespace in 'publish-master.yml'.
- Updated main README.md:
  - Updated license text to link to 'LICENSE.md'.
  - Added 'Maintainers' section.
  - Updated license copyright info.
  - Added github 'build' action worflow badge (for test).
- Removed '.circleci' directory - since github now dows everything we need, via github actions, we don't need to use 'circleci' anymore, also since circleci is closely tied to user account, it's not really ideal, in comparison to github actions, for displaying CI/CD history, and/or, progress, etc.
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Removed '*.md' extension from LICENSE, and MAINTAINERS, …
d086206 
…files.
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Updated github actions 'build' badge, in main README.md.
d29635c
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Updated github workflow file, and action names, to have …
6def076 
…one-to-one correlation to each other.

- Made gh-actions workflow 'job' names more descriptive.
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-\#101 - Removed './ts3.5', and './dist', dirs. from the 'git' c…
df94711 
…ache.
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Moved maintainer/author names from LICENSE file to MAINT…
bd36486 
…AINERS file.

- Updated license to refer to MAINTAINERS file, for copyright info.
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Removed './src/style', and './src/types' exports (ones a…
12a82b4 
…dded to './src/index') - 'export assignments' cannot have adjacent (in same file) export statements (ts. err. TS2309).
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Updated 'Build and Test' gh-actions badge - badge now po…
9918b7c 
…ints to new gh-actions build-and-test action.

 - Re-added attributions, in LICENSE section - These don't really need
to be removed right now.
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
issue-#101 - Removed typo, in README.
63424a5
elycruz added a commit that referenced this issue Sep 1, 2022
@elycruz
Merge pull request #103 from elycruz/dev
6560c7c 
issue-#101 - Updated 'Build and Test' gh-actions badge and LICENSE section in main README (attributions re-addition)
@elycruz
Copy link
Owner Author

elycruz commented Sep 1, 2022

Issue resolved in pull requests #102 , and #103 .

@elycruz elycruz closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elycruz