Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new sass compiler support and css modules support #176

Closed
marcalexiei opened this issue Dec 27, 2024 · 6 comments
Closed

Release new sass compiler support and css modules support #176

marcalexiei opened this issue Dec 27, 2024 · 6 comments

Comments

@marcalexiei
Copy link
Collaborator

Hi @elycruz,
could you please create a new release including #166 (new sass compiler support) and #174 (css modules support)?
Or there is something else that should be done before perfoming a release?

Thanks in advance

@elycruz
Copy link
Owner

elycruz commented Jan 3, 2025

Hey @marcalexiei - no prob. - will push a release this weekend (01/04).

@elycruz
Copy link
Owner

elycruz commented Jan 6, 2025

Hey @marcalexiei - turns out we can't publish the latest with the change that was introduced related to changing the transform method to use the async and await keywords - The package is currently published using the main keyword and the build doesn't transform "empty return" to return Promise.resolve() (see transformed code in './dist/index':

Screenshot 2025-01-06 183914

@elycruz
Copy link
Owner

elycruz commented Jan 6, 2025

@marcalexiei the above is also due to us targeting 'es2015', in base tsconfig.

Note: to allow the latest to be published we just need to make sure that empty returns are actually returning Promise.resolve(), in target transform method.

Also, looks like __awaiter may handle the empty return, but we can't take chances as quite a few packages depend on ours.

@elycruz
Copy link
Owner

elycruz commented Jan 6, 2025

@marcalexiei Also, there was a bug opened previously, for that very same "empty return" line, which was due to us not returning Promise.resolve() from there, so it's validated that this line would case an error in some clients.

@elycruz
Copy link
Owner

elycruz commented Jan 6, 2025

@marcalexiei Nevermind, just reviewed code for the __awaiter it always returns a Promise.

@elycruz
Copy link
Owner

elycruz commented Jan 7, 2025

@marcalexiei Latest version published at v1.15.0.
Closing ticket, also, FYI - CI is failing for windows due to a timeout on OS image fetch (https://github.com/elycruz/rollup-plugin-sass/actions/runs/12642601903).

@elycruz elycruz closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants