[stm32] [timer] [qei] allow configuration of pull-up/down internal resistors on QeiPin

Adjusts the macros for impl<'d, T: GeneralInstance4Channel> QeiPin<'d, T, $channel> to take a 2nd argument which pullup/down should be active for the pins.

Author: leehambley

embassy-stm32/Cargo.toml

@@ -85,6 +85,7 @@ chrono = { version = "^0.4", default-features = false, optional = true }
 bit_field = "0.10.2"
 document-features = "0.2.7"
 
+paste = "1.0.15"
 static_assertions = { version = "1.1" }
 volatile-register = { version = "0.2.1" }
 bitflags = "2.4.2"

embassy-stm32/src/timer/qei.rs

@@ -4,7 +4,7 @@ use core::marker::PhantomData;
 
 use embassy_hal_internal::{into_ref, PeripheralRef};
 use stm32_metapac::timer::vals;
-
+use paste::paste;
 use super::low_level::Timer;
 use super::{Channel1Pin, Channel2Pin, GeneralInstance4Channel};
 use crate::gpio::{AfType, AnyPin, Pull};
@@ -32,16 +32,29 @@ pub struct QeiPin<'d, T, Channel> {
 macro_rules! channel_impl {
     ($new_chx:ident, $channel:ident, $pin_trait:ident) => {
         impl<'d, T: GeneralInstance4Channel> QeiPin<'d, T, $channel> {
-            #[doc = concat!("Create a new ", stringify!($channel), " QEI pin instance.")]
-            pub fn $new_chx(pin: impl Peripheral<P = impl $pin_trait<T>> + 'd) -> Self {
-                into_ref!(pin);
-                critical_section::with(|_| {
-                    pin.set_low();
-                    pin.set_as_af(pin.af_num(), AfType::input(Pull::None));
-                });
-                QeiPin {
-                    _pin: pin.map_into(),
-                    phantom: PhantomData,
+            paste! {
+                fn [<_ $new_chx>](pin: impl Peripheral<P = impl $pin_trait<T>> + 'd, pull: Pull) -> Self {
+                    into_ref!(pin);
+                    critical_section::with(|_| {
+                        pin.set_low();
+                        pin.set_as_af(pin.af_num(), AfType::input(pull));
+                    });
+                    QeiPin {
+                        _pin: pin.map_into(),
+                        phantom: PhantomData,
+                    }
+                }
+                #[doc = concat!("Create a new ", stringify!($channel), " QEI pin instance.")]
+                pub fn $new_chx(pin: impl Peripheral<P = impl $pin_trait<T>> + 'd) -> Self {
+                    Self::[<_ $new_chx>](pin, Pull::None)
+                }
+                #[doc = concat!("Create a new ", stringify!($channel), " QEI pin instance with internal pull-up.")]
+                pub fn [<$new_chx _pu>](pin: impl Peripheral<P = impl $pin_trait<T>> + 'd) -> Self {
+                    Self::[<_ $new_chx>](pin, Pull::Up)
+                }
+                #[doc = concat!("Create a new ", stringify!($channel), " QEI pin instance with internal pull-down.")]
+                pub fn [<$new_chx _pd>](pin: impl Peripheral<P = impl $pin_trait<T>> + 'd) -> Self {
+                    Self::[<_ $new_chx>](pin, Pull::Down)
                 }
             }
         }