Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of inputFiles seems incorrect #71

Open
BryanCrotaz opened this issue Apr 9, 2016 · 2 comments
Open

Documentation of inputFiles seems incorrect #71

BryanCrotaz opened this issue Apr 9, 2016 · 2 comments
Labels

Comments

@BryanCrotaz
Copy link

Readme says inputFiles is an array:

options = options || {};
// options.inputFiles === array of globs, to consider for the cache key

However looking into the code, the default is an empty hash:

this._inputFiles = options.inputFiles || {};

At the least these two don't agree with each other - which one is correct?

@Turbo87 Turbo87 added the bug label May 31, 2016
@Turbo87
Copy link
Member

Turbo87 commented May 31, 2016

that seems to be a bug in the documentation, but I haven't found any code using this option yet to verify how to use it correctly...

@kylecordes
Copy link

Experimentally, it is an array: if you pass it an array of nodes (I've only ever tried with one), it works. If you pass it a single node, it fails with an error. I suspect that bit of code mentioned above is simply a bug which is never hit during correct use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants